Workspace manage page does not allow for pager-less list of changes

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .

The fix looks good, and we should add test coverage for this somewhere in \Drupal\Tests\workspaces\Kernel\WorkspaceAssociationTest.

Added test, so setting to Needs review so that tests run.

The static analysis pipeline is complaining about code not changed in this MR: https://git.drupalcode.org/issue/drupal-3507548/-/jobs/4415362
How should we handle this report?

MR needs to point to 11.x vs 11.1.x

Pipeline appears to have errors too. Just FYI also just pushing the code up the pipeline tests will run. Not like drupalCi that required the ticket to be in review to run :)

The test coverage seems quite heavy-handed for the issue we're fixing here. As mentioned in #5, I still think a simple method in a kernel test that calls WorkspaceAssociation::getTrackedEntitiesForListing() with $limit = FALSE would be better.

krisahil → closed merge request !11239

@amateescu, I rewrote the test as a kernel test in WorkspaceAssociationTest. I also rebased my changes on latest 11.x and replaced the MR with a new one: https://git.drupalcode.org/project/drupal/-/merge_requests/11359

I'll set back to "Needs review".

(Also, thanks for your patient. This is my first attempt at a kernel test.)

https://git.drupalcode.org/issue/drupal-3507548/-/jobs/4559422 shows the test coverage so removing that tag

Reviewing the MR changes look really good, well documented

Don't see any issue LGTM

Thanks @krisahil, we're almost there! Added a comment to the MR, the data provider is not necessary and should be removed :)

Thanks for this lesson, @amateescu. I removed the data provider in latest commit.

@amateescu that was my mistake for not catching it. Conversion from dataprovider appears to be completed though.

Looks great to me as well, thanks for sticking with it :)

Committed/pushed to 11.x and cherry-picked to 10.5.x, thanks!

catch → closed merge request !11359

Tests were failing on 10.5.x so reverted, moving this back to 11.x for now and leaving fixed, but could be properly backported with a backport MR if desired.

Automatically closed - issue fixed for 2 weeks with no activity.