Contrib.social

Bootstrap root.css is loaded by default in varbase_components module, causing conflicts with custom Bootstrap themes

Open on Drupal.org →
Created on 17 February 2025, 3 months ago

Problem/Motivation

The varbase_components module always loads root.css for the default Bootstrap framework,
which causes conflicts when using a custom Bootstrap theme. The custom Bootstrap styles are overridden by
the default root.css provided by the module.

Steps to Reproduce

  1. Install varbase_components.
  2. Copy all the components inside a new custom theme and add a replace key inside the *.components.yml file as per the documentation.
  3. Perform a full theme build and notice that the custom Bootstrap styles are still overridden by the default
    root.css provided by the module. This is caused by the following dependency in ckeditor5-styles: 
    # Ckeditor 5 styles.
ckeditor5-styles:
  dependencies:
    - core/components.varbase_components--root
    - core/components.varbase_components--alert
    - core/components.varbase_components--callout
  4. I've overridden this library with a custom theme library but without the
    - core/components.varbase_components--root, and then everything worked as expected.

Proposed Resolution

Remove the - core/components.varbase_components--root from the ckeditor5-styles library
inside this module or load it on demand.

Remaining tasks

  • ✅ File an issue about this project
  • ❌ Addition/Change/Update/Fix to this project
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Code review from 1 Varbase core team member
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇯🇴Jordan mohammad-fayoumi Amman

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024