Dialog + Media Library refinements to support Gin

I uploaded a patch → that Gin will need to make it work (and will file an issue for it - the closet issue is filed in Gin toolbar and not gin)

Most of the support can be taken care of on the Experience Builder end, and the MR is full of that

Experience Builder

Regular Gin

Most recent changes to the MR addresses the buttonpane weirdness. The drop shadow still isn't getting in for some reason - I still need to figure that out - but I'm going to switch to NR so interested parties can start looking at it.

Reviewed the back-end bits.

Who should review the FE bits? Or, do you feel this needs no further review, @bnjmnm?

Or, do you feel this needs no further review, @bnjmnm?

There should at least be one additional person manually confirming Gin seems good and Claro didn't regress. There's still the drop shadow mystery I need to figure out too, but could see the benefit of getting the significant improvements provided here merged (it goes from unusable to completely usable) and the fine tuning can happen with a bit less urgency and perhaps a good newer-contributor issue.

I checked that Claro still looks the same on this MR and 0.x.

There are just two things:
1. I'm unable to enter alt text after selecting an image for some reason. I can't on 0.x either so that should not affect this issue but just wanted to call it out.

2. My XB media library Gin looks different than the ones in the screenshots from #2 📌 Dialog + Media Library refinements to support Gin Active

Here is what mine looks like (I did apply the patch and checked that the changes applied to gin.libraries.yml and I cleared cache)

We discovered #7 was due to triggering the media library from somewhere other than the article props form, which is currently the only supported way to do this, but will soon be available to other uses 📌 Exapand Media Library admin theme rendering beyond props form. Active (that issue is ready, the test fails are unrelated to the MR)

Leaving what i did here, since someone else should test this because I am getting weird colors in my XB gin media library.

My testing steps after applying patch from #2:

1. Applied gin patch from #2
2. Reinstalled drupal
3. Installed xb_dev_standard to create an article for xb
4. Changed admin theme to Gin
5. Merged in MR from https://git.drupalcode.org/project/experience_builder/-/merge_requests/643 so I am able to place an Image onto XB without it breaking.
6. clear cache
7. Place image onto XB and open media library
6. See screenshots.

Thanks @hooroomoo! looks like #9 happens with aggregation on. Time to dig further.

The issue spotted in #9 made it apparent that I needed some additional changes for it to work right with aggregation, which is fixed in d7e0ea26

The trickiness is due to single variables being assigned new values in the same css file that then uses those variables. It's no problem when they are separate files, but when aggregated together there needs to be additional logic to ensure the dialog scoped version manages the variable values correctly.

The e2e tests need to be refactored because the less aggressive variable replacement means I cant use CSSStyleSheets the same way in the test. This can be reviewed without waiting on those tests, though.

wim leers → credited jessebaker → .

• I approved the BE in #5.
• @hooroomoo did manual testing in #7 and found 2 things.
• @bnjmnm dug into #7 and found it was due to 📌 Exapand Media Library admin theme rendering beyond props form. Active not having been fixed yet. That has now been fixed!
• @jessebaker did a review of the FE code at https://git.drupalcode.org/project/experience_builder/-/merge_requests/6...

• First E2E test run: 1 fail: undo-redo
• Second E2E test run: 2 fails: component-operations + drag-and-drop.

This means they're random, not consistent fails.

Going ahead and merging.

Automatically closed - issue fixed for 2 weeks with no activity.