Exapand Media Library admin theme rendering beyond props form.

XB Page - Page Data (no buttons - as was the case pre-#3471978)

Article - Page Data (no buttons - as was the case pre-#3471978)

XB Page - Props (the "add media" button does not work reliably, which is not in this issue's scope. It was the case pre-#3471978 and will likely be fixed with the solution reported in 🐛 Image can only be replaced one time before "add media" stops working Active

Note the test failures in the pipeline are unrelated to the changes in this issue. You can see PHPUnit passing on the previous major runs

I manually tested this and can confirm that the media library styles look good when clicking from the Page data form from both Article and an XB_Page.

But I am unable to check for regressions from opening from the props form because I'm unable to add an image to XB because of this issue: https://www.drupal.org/project/experience_builder/issues/3501902 🐛 Adding the Image component results in a state considered invalid Active .

(I tried testing it with an in-progress MR from that issue and it let me place an image to XB but it does not open the media library dialog when i click "Add media")

The "add media" button can get a little flaky if it is used multiple times, not related to the changes in this issue. There's an NR merge request that addresses that here: 🐛 Image can only be replaced one time before "add media" stops working Active

The styles seem to be loading fine but the dialog buttons are not working. If we're not fixing it here, we'll need a follow-up for that.

Just to clarify, what was spotted in #11 was mentioned in the summary.

I feel it's important to clarify it is something that props-form-triggered media library widgets have never been capable of doing, and not an issue introduced by any of the theming efforts, nor should it be within the scope of those. The need to get this working should be reflected in the issue queue, of course, but (at the risk of nitpicking) it's not a followup to this issue - it's just one of many things that need to happen as part of constructing Experience Builder.

But yep lets be sure it is documented and findable in the issue queue 📌 Media Library dialogs triggered from page data do not have buttons yet Active

wim leers → made their first commit to this issue’s fork.

This improves on the status quo. Let's get it in.

Automatically closed - issue fixed for 2 weeks with no activity.