Cannot disable Menu Link unless Taxonomy term is unpublished

This affects us as well.

The patch could be simplified a bit. The following one line change does the job as well:

-    if (!empty($link)) {
+    if (parent::isEnabled() && !empty($link)) {

Ultimately this is a question of coding style. I do not have any preference on how the issue is resolved.

We are also experiencing this. The provided patch resolves the issue.

I'm sorry that the other bug fix introduced this bug.

Let's expand the test coverage to make sure this doesn't come back to haunt us again.

@veronicaseveryn thanks for patch!
+1 for patch #2

changing priority to critical

Can confirm that the patch #2 fixed the issue for us as well.

Working on tests.

Pushed a test which passes with the fix and fails without.