Convert line breaks into HTML does not convert "\n"

Open on Drupal.org →

Created on 3 February 2025, 5 months ago

Problem/Motivation

The views field rewrite option "Convert line breaks into HTML" does not rewrite "\n" to "
" as described here:
https://www.drupal.org/docs/8/core/modules/views/rewrite-the-output-of-a... →

Convert newlines to HTML
tags If this option is enabled, all newline characters (e.g. \n) are converted into break tags.

This may in fact be a bug with the filter module, not views (see _filter_autop()).

Steps to reproduce

Edit any entity that has a field that uses text formats.
Ensure the value of the field contains "\n", for example: "Contributor,\n Foundation Contributor,\n Support".
Create a view of the entity field.
Enable "Convert line breaks into HTML" under rewrite options.
Save the view or look at the preview.
Notice the field renders without converting "\n" to "
". For example it simply renders: "Contributor,\n Foundation Contributor,\n Support".

Proposed resolution

Make the rewrite option do what it is documented as doing.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Active

Version

11.1 🔥

Component

views.module

Created by

🇺🇸United States maskedjellybean Portland, OR

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!11106Convert line breaks into HTML does not convert "\n"
Open
🇮🇳India annmarysruthy
updated 5 months ago

Comments & Activities

Issue created by @maskedjellybean
Comment 5 months ago →
🇺🇸United States maskedjellybean Portland, OR
Comment 5 months ago →
🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .
First commit to issue fork.
Merge request !11106Issue #3504118: Convert line breaks into HTML does not convert "\n" → (Open) created by annmarysruthy
Pipeline finished with Success
5 months ago
Total: 352s
#414687
Comment 5 months ago →
🇮🇳India annmarysruthy
Raised MR#5. Kindly review.
Comment 5 months ago →
🇺🇸United States smustgrave
Seems like something we should have test coverage for.
Pipeline finished with Success
5 months ago
Total: 2772s
#415377
Comment 5 months ago →
🇮🇳India annmarysruthy
Added tests in Merge request !11106. Kindly review
Comment 5 months ago →
🇺🇸United States maskedjellybean Portland, OR
Wow, thank you @annmarysruthy! I didn't expect to have a fix so quickly. A patch from the MR fixed the issue! The test seems to make sense. Thanks again.
Comment 4 months ago →
🇺🇸United States smustgrave
Not 100% sure about the solution. Not sure if there is a function that can called to do some of this and more but does address the issue. Will let committer decide if its good enough.
Comment 4 months ago →
🇬🇧United Kingdom longwave UK
I'm not convinced this is the intent of the feature, when it says \n I think it means a literal line break (aka the newline character) and not the actual string \n.
Comment 4 months ago →
🇺🇸United States smustgrave
Should we move back to NW for a new solution?
Comment 4 months ago →
🇬🇧United Kingdom longwave UK
Well, I'm not convinced this is a bug at all; the option is called nl2br because it calls nl2br() on the output, and that presumably works as intended (although the additional test coverage here is nice, because currently we don't have any).

Also not sure the test exercises the bug from reading it, running the test-only job to find out.
Comment 4 months ago →
🇬🇧United Kingdom longwave UK
The test-only job passes without the fix, which means the test isn't demonstrating the problem described here.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024