The translation submodule does not respect the content translation module permissions

I did not test it but the code looks sound.
I'm not sure, should we also check $account->hasPermission('translate any entity') OR will that happen automatically in $handler->getTranslationAccess($entity, 'create')->isAllowed()?

mrdalesmith → changed the visibility of the branch 3503980-the-translation-submodule to hidden.

@rhristov should this be in needs review?

Tested the MR !446. On applying the changes, :

1. The user can translate the content in which user has translate permission. Also if user has 'Translate any entity' permission, the 'Translate using @ai' button appears. Otherwise, N/A will appear under AI translations

annmarysruthy → changed the visibility of the branch ai-3503980-1.0.x to hidden.

Bumping the version + MR is not mergable at the moment

annmarysruthy → closed merge request !484

While trying to rebase the MR!446 accidently created a new MR. Closed new MR !484.

Bumping the version (again)

valthebald → changed the visibility of the branch 1.0.x to hidden.

I've reworked original idea, and added the logic to hide "AI translations" column when user doesn't have permissions or all languages are already translated

Tested this MR.

I removed all content_translation permissions from a given user.
They could no longer see the "Translations" tab in that case.

However, when given the "Create AI translation" permission, they could still access the translation URL directly, and a translation was added.
Not sure if this is desired behaviour, or if it should be an AND operation: only create AI content translations when you have "create ai content translation" permission + the appropriate content_translation permission as well.

So the original issue raised in this topic was not yet fixed, AFAIK.

The improved logic to hide the AI Translation column when not relevant, seems to work and is definitely an improvement.