- Issue created by @quietone
- Merge request !11086Resolve #3503912 "Fix drupal.commenting.functioncomment.missing in Plugins" → (Open) created by quietone
- First commit to issue fork.
- 🇫🇷France nod_ Lille
CI is green but pre-commit checks are not, and can't commit. Getting
Running PHPStan on changed files. ------ ----------------------------------------------------------------------------------------------------------------- Line modules/filter/src/Plugin/Filter/FilterHtml.php ------ ----------------------------------------------------------------------------------------------------------------- 268 Method Masterminds\HTML5\Parser\Tokenizer@anonymous/modules/filter/src/Plugin/Filter/FilterHtml.php:265::setTextMode() has no return type specified. 🪪 missingType.return ------ ----------------------------------------------------------------------------------------------------------------- [ERROR] Found 1 error
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇳🇿New Zealand quietone
I am confused by this. The baseline does have an ignore line, which is
$ignoreErrors[] = [ 'message' => '#^Method Masterminds\\\\HTML5\\\\Parser\\\\Tokenizer@anonymous/core/modules/filter/src/Plugin/Filter/FilterHtml\\.php\\:268\\:\\:setTextMode\\(\\) has no return type specified\\.$#', 'identifier' => 'missingType.return', 'count' => 1, 'path' => __DIR__ . '/modules/filter/src/Plugin/Filter/FilterHtml.php', ];
The difference is that the base line has
/core/modules/filter
but the pre-commit check has/modules/filter
.It can be fixed by adding a void return to the function, but that is out of scope.