- Issue created by @drunken monkey
- ๐ฎ๐ณIndia niranjan_panem Gurugram
I tested the issue, views-pages and exposed forms are working fine in drupal, but not able to reproduce the issue.
- ๐บ๐ธUnited States bnjmnm Ann Arbor, MI
Given that I've had to reopen several issues incorrectly closed by @niranjan_panem and
I tested the issue, views-pages and exposed forms are working fine in drupal, but not able to reproduce the issue.
Doesn't provide enough detail to indicate the steps to reproduce were followed, this may not have received the due diligence required to justify setting this to Closed (cannot reproduce)
- First commit to issue fork.
- Merge request !11164Issue #3503878: TypeError when having exposed form in block and setting "role" attribute on it โ (Open) created by riyas_nr
I have implemented a fix to ensure that when
$variables['label']
is an array, it gets rendered into a string before assigning it totitle_attributes['id']
. This prevents theTypeError
when setting form attribute$form['#attributes']['role'] = 'search';
Additionally, I have added a PHPUnit test to verify this.
- ๐บ๐ธUnited States smustgrave
Issue summary needs some work as the proposed solution is not flushed out.
Left a comment on the MR.
Moved the Views exposed filter test to the Search integration test file, as this test verifies that when the
search
role is assigned to the Views exposed form, thearia-describedby
attribute is correctly set without aTypeError
. This issue occurs only when the Views exposed form label is rendered as an array.As per the MR comment, I have also added test coverage for the Block module by adding the role attribute for a standard block and verifying the normal label scenario.
- ๐ฆ๐นAustria drunken monkey Vienna, Austria
@riyas_nr: This looks great to me, thanks a lot for your work on this! Setting to RTBC.
I amended the โProposed resolutionโ section of the IS.