- Issue created by @pameeela
- π©πͺGermany jurgenhaas Gottmadingen
pameeela β credited jurgenhaas β .
- π¦πΊAustralia pameeela
Created an MR for this, crediting Jurgen for providing the initial model config.
- πΈπ°Slovakia poker10
Why we want this change to be done in Drupal CMS, instead of Project Browser? If we change it only in Drupal CMS, then users of Drupal CMS will have different tabs than users with only Drupal Core + Project Browser installed, which could be confusing.
- πΊπΈUnited States phenaproxima Massachusetts
This should not happen in Project Browser because it has its own IA and requirements that may be (are) are different than ours. Rather than try to persuade Project Browser's maintainers to alter their UX while the current release is utterly broken due to upstream changes on drupal.org, I think it's best to get this done now, however we can.
Besides, trying to rename tabs will very definitely cause an endless bikeshed that we simply do not have time for right now.
If you feel strongly about this, by all means open an issue in Project Browser -- I'm sure they can be convinced to change the local tasks' titles and ordering, but it will take some back-and-forth.
So yes - I'm accelerating this in favor of improving the UX for our users sooner rather than later. If Project Browser gets better task titles in its next release, we can remove the ECA model.
- πΊπΈUnited States phenaproxima Massachusetts
Although it is a feature request, I think it's okay for this to land in a patch release because it's a much-desired UX improvement that won't hurt existing sites -- really a deferred thing from our launch, as I pointed out in #6 -- that will only help users. I could even argue that it is a bug fix, because the local task labels we were forced to launch with were, in a sense, a bug that we were unable to fix in time.
- πΈπ°Slovakia poker10
I was just saying, that it does not seems right to have a different UI while still in the same product - Drupal. So even if we commit this to Drupal CMS, I think there is only one way forward and that is to change it in Project Browser to have it the same. Not sure how we will be able to exaplain users of Drupal core + Project Browser (or later only Drupal core), why is their menu/tabs different from the Drupal CMS. Not saying about documentation, etc..
- πΊπΈUnited States tim.plunkett Philadelphia
Thanks for your input @poker10. Drupal CMS and Drupal Core are different products.
- πΊπΈUnited States phenaproxima Massachusetts
Tests are passing, I manually tested and it works nicely. Merging.
-
phenaproxima β
committed d3fb5a1f on 1.x authored by
pameeela β
Issue #3502997 by pameeela, phenaproxima, jurgenhaas: Override Project...
-
phenaproxima β
committed d3fb5a1f on 1.x authored by
pameeela β
-
phenaproxima β
committed 0698340d on 1.0.x authored by
pameeela β
Issue #3502997 by pameeela, phenaproxima, jurgenhaas: Override Project...
-
phenaproxima β
committed 0698340d on 1.0.x authored by
pameeela β
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 1.x and cherry-picked to 1.0.x. Thanks @pameeela and @jurgenhaas!
- πΈπ°Slovakia poker10
To put it another way, I think that one of the benefits of Drupal CMS should be, that it should help Drupal core - e.g. bring things that are beneficial for all users to core, not to create differences in the basics (with the assumption that non Drupal CMS users will manage somehow).
Yes, the "product" term was not right, better term seems to be "system", because once you install Drupal CMS and apply recipes, it is Drupal core + contribs + custom config.
I created an issue in Project Browser: β¨ Update local task titles to match Drupal CMS changes Active .
Looking at the renamed "Recommended" tab, we are now using also the term "Add-ons" in Dashboard π "add-ons" vs. "recipes" Active , so currently one tab in Project Browser could have three different "names" -
Add-ons
,Recipes
,Recommended
. I am also curious if this tab name will need to change when other recipes will be displayed in that tab? Project Browser can eventually allow it sometimes in the future and there is no upgrade path for existing Drupal CMS users, to change the tab name back/to a different title. - πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
I have also concerns with this solution because of translatability.
Automatically closed - issue fixed for 2 weeks with no activity.