- Issue created by @anjaliprasannan
- 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
I have reviewed the !226 Mr and its Working Fine as per the issue requirement.
i have attached the Screenshot For reference.Suggestion :
i have one more suggestion can we include the Date selector for the range filter so we can easily filter the data.
also added the Screenshot For the what kind of popup we can add. - 🇬🇧United Kingdom jonathan1055
Hi @anjaliprasannan thanks for working on this, it is a good idea. Thank you also @prem suthar for the feedback, yes it should definitely use thr calendar pop-up.
Three other points:
- This change should be done for the views of all of the built-in entity types that Scheduler supports, so that would be Media, Commerce Products and Taxonomy Terms
- The user scheduled views should also match the filters of the main admin view, so that would be Node and Media (because there are no user views for Product or Term)
- New features should have test coverage, to prove they work. You can add new tests in
tests/src/Functional/SchedulerViewsAccessTest.php
- 🇬🇧United Kingdom jonathan1055
You have created the filter for "authored on" but it would be equally likely that you would want to filter by the date for scheduled publishing/unpublishing. But adding that as a separate box would make the UI clumsy. It is possible to have a modular type of filter, where you choose a date (authored on, publish on, unpublish on, etc) then pick the condition and the date(s). That would give lots of flexibility and increased functionality.
- 🇮🇳India anjaliprasannan
@prem suthar The date picker issue is already reported in ✨ [PP-2] Use form element of type date instead textfield when selecting a date in an exposed filter Needs work and once it is fixed it would appear as date selecter.
@jonathan1055 covered the point 1 in the commit. working on test case.