- Issue created by @pdureau
- π«π·France Grimreaper France π«π·
pdureau β credited grimreaper β .
- Merge request !331Issue #3502069 by pdureau, grimreaper, just_like_good_vibes: Duplicate blocks when nested ComponentLayout with Layout Builder β (Merged) created by just_like_good_vibes
- π«π·France pdureau Paris
Let's review this very carefully. It is only one line of code for now, but Layouts plugins are used in some weird ways in Drupal, and we don't want to fix on one side to break in the other.
$build[$region_name] = $regions[$region_name]; $build[$region_name] = &$build['#slots'][$region_name];
Also, let's update the comment before with tne new situation:
// For layout builder we need to pass slots also // direct to the build array. They are needed to generate contextual // links and other surrounding markup. // This makes field layout forms empty. // Not sure how to handle this. Should we support field_layout?
- π«π·France Grimreaper France π«π·
Hi,
Thanks a lot for the bug fix!
I confirm it fixes the issue.
- π«π·France just_like_good_vibes PARIS
i let christian update the comment on the original code.
i just posted the fix :) - π©πͺGermany Christian.wiedemann
christian.wiedemann β made their first commit to this issueβs fork.
- π©πͺGermany Christian.wiedemann
Looks good for me. Also field_layout with forms works now. Great. I added a check to test if the layout builder specifcs are added.
-
pdureau β
committed 8b93a527 on 2.0.x authored by
just_like_good_vibes β
Issue #3502069 by just_like_good_vibes, christian.wiedemann, pdureau,...
-
pdureau β
committed 8b93a527 on 2.0.x authored by
just_like_good_vibes β