PHP 8.4 deprecation warnings in Search API module

Created on 20 January 2025, 2 months ago

Updated 21 January 2025, 2 months ago

When using PHP 8.4 with Drupal 10 and the Search API module, the following deprecation warnings are encountered:

_search_api_views_handler_adjustments(): Implicitly marking parameter $sub_type as nullable is deprecated.
File: /app/web/modules/contrib/search_api/search_api.views.inc, Line: 445.
Drupal\search_api\Entity\Index::setServer(): Implicitly marking parameter $server as nullable is deprecated
File: /app/web/modules/contrib/search_api/src/Entity/Index.php, Line: 523

Set up a Drupal 10 site with PHP 8.4
Install and enable the Search API module (latest version)
Start the project
Check the error logs or enable deprecation warnings display in your development environment
Observe the deprecation warnings related to the Search API module

Update the affected functions to explicitly declare nullable parameters:

In search_api.views.inc, update the _search_api_views_handler_adjustments() function signature to explicitly declare $sub_type as nullable.
In src/Entity/Index.php, update the setServer() method signature to explicitly declare $server as nullable.

Implement the proposed changes in the affected files
Test the changes to ensure they resolve the deprecation warnings without introducing new issues
Create a patch file with the changes
Update this issue with the patch file and test results
Review and test the patch by the module maintainers
Commit the changes to the Search API module repository

🐛 Bug report

Status

Active

Version

1.0

Component

General code

Created by

🇺🇸United States ryankolsen South Carolina

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 2 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Comment 2 months ago →
🇩🇰Denmark ressa Copenhagen
Tagging with PHP 8.4, to easier follow along.
Comment 2 months ago →
🇺🇸United States ryankolsen South Carolina
Comment 2 months ago →
🇺🇸United States ryankolsen South Carolina
Already Resolved

If someone can double check me, I think this has already been resolved in Git commit # 17bf61a7b7e96d13a221597d63dfb43c0e7472aa, here is the link to the issue Issue 3492380 📌 Nullable types must be explicit Active .

Sorry, I went to make these changes in the repo and found them already done.
Comment 2 months ago →
🇺🇸United States ryankolsen South Carolina
Duplicate of

Existing Issue 📌 Nullable types must be explicit Active

Production build 0.71.5 2024