- Issue created by @claudiu.cristea
- Merge request !169Issue #3500847: Fix parameters marked as nullable implicitly. → (Open) created by divyansh.gupta
- 🇮🇳India divyansh.gupta Jaipur
I have made changes to remove implicitly parameters as nullable error on PHP8.4.
Please review. - 🇷🇴Romania claudiu.cristea Arad 🇷🇴
Thank you, @divyansh.gupta
But now we need to run tests also with PHP 8.4 in pipeline. Let's start by adding
OPT_IN_TEST_MAX_PHP: 1
undervariables:
in https://git.drupalcode.org/project/paragraphs/-/blob/8.x-1.x/.gitlab-ci.yml - 🇮🇳India divyansh.gupta Jaipur
@claudiu.cristea, Added it in the Gitlab-Ci file.
Please review. - 🇷🇴Romania claudiu.cristea Arad 🇷🇴
Thank you. I see the PHP 8.4 phpunit test is failing
- 🇮🇳India divyansh.gupta Jaipur
@claudiu.cristea
I have looked all the errors in the pipeline most of them are related to contrib or core files and there are no errors related to paragraph module files,
Please review. - 🇨🇭Switzerland berdir Switzerland
There's an older, existing issue, please ensure that covers the same changes: 📌 Nullable types must be explicit Active