- Issue created by @larowlan
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This to me is definite polish, a nice-to-have, not a must-have for π± Milestone 0.2.0: Experience Builder-rendered nodes Active .
Why?
Because:
- 99% of
BlockPluginInterface
implementations' forms do not have any validation at all β client nor server-side. The range of possible settings values allowed through the UI is constrained only by the HTML input element they picked (<select>
,<input type="checkbox">
, etc.) - It's only since a few months (since π Make Block config entities fully validatable Fixed ) that a few block plugins are fully validatable β¦
- β¦ and it's only those few block plugins that have a precise config schema that would even allow for this! π°
- I'm convinced that >50% of placed blocks contain invalid/nonsensical block settings, that only sort of work due to PHP's automatic typecasting β having worked on https://www.drupal.org/project/acquia_migrate β , and having seen the incredibly weird/convoluted/puzzling "settings" many placed blocks were accepting without complaining.
- Actually, even outside a migration context, the only reason block plugins' settings forms work at all is precisely because both the PHP typecasting magic in the form definition is matched with the Form API submission typecasting magic, and is matched with the block plugin's
::build()
method's interpreting of the saved values
- 99% of
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π Implement saving block settings forms Active is in, but I imagine we'll at least want to do π [PP-2] Remove InputBehaviorsBlockSettingsForm and consolidate with input components form Active first?
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π [PP-2] Remove InputBehaviorsBlockSettingsForm and consolidate with input components form Active is in, too.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
π Decouple generated source plugins from SDC plugins Active blocks this in my book
- Status changed to Postponed
3 days ago 2:47pm 9 May 2025 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Per #3513589-6: [PP-1] Decouple generated source plugins from SDC plugins β , that is PP-1.