Person base recipe view does not offer an "Add a person" button

This is a good start but as @narendraR points out, the Person recipe also needs to adjust its dependencies properly.

Thanks @phenaproxima - I'm new at contributing code so bare with me as I stumble through this :) I've updated the MR with the necessary dependencies. I've also (I think) added the automated test as you mentionned.

That looks pretty much correct to me!

There is only one outstanding piece of feedback -- I suspect you copied and pasted from the Blog view and forgot to update one line. ;)

I've tested and it is working as expected.

There is an accessibility issue with the hover for the button (can't tell you are selecting it), but it's the same issue on all of them, so I'll create an issue if there isn't one already.

The issue with tests not passing is probably unrelated, but I'll check the errors.

https://youtu.be/lpjY7P3PTm8

Quickly skimmed test errors and they seem unrelated.

In #6, @phenaproxima seemed pretty happy with things and you changed the one thing he noticed.

Back to needs review for his blessing.

Thanks - for the hover issue; I took a quick peek as I would have noticed as well. Seems like it's only affecting Webkit browsers (Safari) for me on Linux (haven't tested on another platform though).

Code looks good to me and has my sign-off; the test failures were the usual random MySQL-related nonsense. Leaving the RTBC for someone else. :)

@kristen pol created the follow up issue.

Thanks for the contribution and the thorough reviews! Resolved all threads and moving to RTBC.

Merged into 1.x and ported to 1.0.x due to a merge conflict in recipes/drupal_cms_person/composer.json which shouldn't have happened at all, but better to discover it now than later. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.