- Issue created by @ekes
- 🇦🇺Australia dpi Perth, Australia
Thanks, I can see weekly test runs are failing since core 11.1.
If you can get the tests passing again, that would satisfy this issue.
- Merge request !51Issue #3498936: DateTime Range Views Data was converted to a class, hook and .inc removed → (Merged) created by ekes
- 🇳🇱Netherlands ekes
Passes PHPUnit.
I don't thing the cspell, phpstan, phpcs are related to this change?
- 🇦🇺Australia dpi Perth, Australia
Checked the linting issues, you can ignore.
Feedback already there.
Does this work for 11.0 also? If not, might need to make the to-be-changed-to-autowired service arg optional (make nullable) and call function if service not injected. e.g
$this->hookservice?->method() ?? \call_old_function();
- 🇦🇺Australia dpi Perth, Australia
Autowired services are available by their classname as ID. So for plugins, or anything using containerinjection interfaces, or even
\Drupal::service(...)
, you should do$container->get(DatetimeRangeViewsHooks::class),
- 🇦🇺Australia acbramley
Does this work for 11.0 also
Unfortunately not, this class only exists on 11.1
- 🇦🇺Australia acbramley
Solution is there, just need to figure out how to run previous minor on 8.3
- 🇦🇺Australia dpi Perth, Australia
Merged. CI: PHPUnit still red so no release quite yet.
Automatically closed - issue fixed for 2 weeks with no activity.