- Issue created by @pameeela
- π¦πΊAustralia pameeela
For better or worse, this is done. Probably should have split the person card styles into a new component but hey, I didn't.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I'm going to test this.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Add design to summary.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
The styling I'm seeing doesn't matching the designs so maybe I have the wrong one?
One person
Two people
Four people
(3 people looks the same but just one row)
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
- Design doesn't show the summary, so should we?
- Given we are running out of time, should we try to get the 2+ layouts to look more similar to the design?
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Some other things:
- Adding content on the people node did put content on the page above the view
- If you edit the people node and add tags, they don't show up on the page... should those be marked as bugs and fixed after today?
- The profile page doesn't match the design either, see below... should those be marked as bugs and fixed after today? maybe this is a different issue
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Added bug issue based on discussions with @phenaproxima:
π Node edit form for views listings should hide tags field Active
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Unassigning so @pameeela or @mherschel can respond to feedback...
Consolidating it all into this comment:
- Unclear on asterisk in
*aspect-ratio: 16/9;
- Design doesn't show the summary, so should we?
- Given we are running out of time, should we still try to get the 2+ layouts to look more similar to the design?
- The profile page doesn't match the design either... ah... I see this now: π Implement designs for case person profile full page display within Olivero Active
- Unclear on asterisk in
- πΊπΈUnited States phenaproxima Massachusetts
One or two small things found in the code but otherwise this is probably ready for final review by @pameeela.
- πΊπΈUnited States phenaproxima Massachusetts
Fixed those two things, and the failing tests (bad dependencies -- good thing we're testing for that!)
- π¦πΊAustralia pameeela
Happy with this, I added the description because 1) it looked kind of weird with nothing else and 2) if we didn't show the description here we don't show it anywhere so that makes no sense!
- πΊπΈUnited States mherchel Gainesville, FL, US
phenaproxima β credited mherchel β .
-
phenaproxima β
committed c39909b5 on 1.x authored by
pameeela β
Issue #3498651 by pameeela, phenaproxima, kristen pol, mherchel:...
-
phenaproxima β
committed c39909b5 on 1.x authored by
pameeela β
-
phenaproxima β
committed 40b2d5d1 on 1.0.x authored by
pameeela β
Issue #3498651 by pameeela, phenaproxima, kristen pol, mherchel:...
-
phenaproxima β
committed 40b2d5d1 on 1.0.x authored by
pameeela β
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 1.x and ported to 1.0.x. Thanks all!
Automatically closed - issue fixed for 2 weeks with no activity.