- Issue created by @pameeela
- π¬π§United Kingdom tonypaulbarker Leeds
I am figuring out the hero image styles across the content types at https://www.drupal.org/project/drupal_cms/issues/3495584 π Implement hero images to match designs Active
and the classes to set the content widths of the node content across the content types at https://www.drupal.org/project/drupal_cms/issues/3495583 π Implement full node content widths to match designs Active
- πΊπΈUnited States bernardm28 Tennessee
Is a person coming out of people? if so, new fields are needed to meet that design. if not, should it be its own content type? which does not seem to have been created yet.
- π¬π§United Kingdom tonypaulbarker Leeds
I'm un-assigning myself to look at another task if someone would like to pick this up.
A couple of configuration / mark up notes. It looks as though we want to go with a layout builder 2 column with 25% 75% widths. Set the global title block to be hidden for profiles/* and add the name field to the right hand column in LB. Ensure that the name is using an H1 tag.
- π¦πΊAustralia pameeela
Uploaded a modified design with the title above the content, definitely don't want to get into messing with the global title block just for this one case.
- πΊπΈUnited States mherchel Gainesville, FL, US
Overall this is looking great! There are some inconsistencies:
- The image should be vertically aligned with the content.
- The icons are not showing
- Too much space between the image and the titile/phone/etc
- πΊπΈUnited States mherchel Gainesville, FL, US
I'm going to work on this right now to fix the issues in #17
- πΊπΈUnited States mherchel Gainesville, FL, US
It looks like you forgot commit the code to attach the CSS, which is why it didn't look quite right!
Anyway, I fixed that, and also adjusted the top layout to remove the extra spacing. Should be good!
- πΊπΈUnited States phenaproxima Massachusetts
Back to Pam for final review but I have no objections myself.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I tested over here π Implement & style person card & listing page Active but then found this issue...
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Added issue for tags label as I didn't find one: π Tags label should be capitalized to match design Active
-
phenaproxima β
committed 90b30136 on 1.x authored by
pameeela β
Issue #3491814 by pameeela, mherchel, kristen pol: Implement designs for...
-
phenaproxima β
committed 90b30136 on 1.x authored by
pameeela β
-
phenaproxima β
committed 149e0e65 on 1.0.x authored by
pameeela β
Issue #3491814 by pameeela, mherchel, kristen pol: Implement designs for...
-
phenaproxima β
committed 149e0e65 on 1.0.x authored by
pameeela β
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 1.x and cherry-picked to 1.0.x.
Automatically closed - issue fixed for 2 weeks with no activity.