- Issue created by @poker10
- First commit to issue fork.
- Merge request !505Issue #3498036: Add test for Sitemap module enabled plugins β (Merged) created by riyas_nr
Added a functional test to verify sitemap module plugins are enabled by default.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Looks good to me. Over to Adam for final review. Marking as RTBC.
- πΊπΈUnited States phenaproxima Massachusetts
I think this test is worthwhile to have but I'm not sure it's testing the most useful aspects of this.
For example, we don't need to check that the specific plugin checkboxes are checked, we just need to be sure that /sitemap has what we expect it to. Ideally we would not rely on CSS selectors at all, since they can change out from under us.
Self-assigning to see if I can optimize this a bit.
- πΊπΈUnited States phenaproxima Massachusetts
Made a few changes:
- Everything now happens in checkSitemap(), so that the test happens for authenticated and anonymous users
- I don't bother testing the admin side, as it's beside the point. We care that the sitemap looks a certain way, not that configuration flags are correct
-
phenaproxima β
committed 16c2a799 on 1.x authored by
riyas_nr β
Issue #3498036 by phenaproxima, riyas_nr, poker10, thejimbirch: Test...
-
phenaproxima β
committed 16c2a799 on 1.x authored by
riyas_nr β
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 1.x and cherry-picked to 1.0.x, as this is a test-only change. Thanks!
-
phenaproxima β
committed 0353b281 on 1.0.x authored by
riyas_nr β
Issue #3498036 by phenaproxima, riyas_nr, poker10, thejimbirch: Test...
-
phenaproxima β
committed 0353b281 on 1.0.x authored by
riyas_nr β
Automatically closed - issue fixed for 2 weeks with no activity.