- Issue created by @poker10
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Great issue! This was not possible with recipes when this recipe was created. Since the Sitemap module keeps the plugins in its sitemap.settings.yml, we were not able to change that file and continue to be idempotent.
With the introduction of config:strict in 10.4, we now can.
We want:
page_title: Sitemap path: /sitemap message: value: '' format: plain_text plugins: frontpage: base_plugin: frontpage enabled: true weight: 0 settings: title: 'Front page' rss: /rss.xml id: frontpage provider: sitemap 'menu:main': base_plugin: menu enabled: true weight: 0 settings: title: 'Main navigation' show_disabled: false id: 'menu:main' provider: sitemap include_css: true
Instead of:
page_title: 'Sitemap' path: 'sitemap' message: format: 'plain_text' value: '' plugins: [] include_css: true
- Merge request !313Enables Frontpage and Main menu Sitemap settings β (Merged) created by thejimbirch
- πΊπΈUnited States phenaproxima Massachusetts
One minor stylistic question. This would probably also benefit from a very simple test of some kind, just to prevent it from regressing in the future.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Updated formatting, but still needs tests.
- π¦πΊAustralia pameeela
It would be good to have this fixed for now, but add a follow up for adding a test. It's pretty low risk since the only way it would "break" is if someone intentionally changed the config.
- πΊπΈUnited States phenaproxima Massachusetts
Yeah, I agree, let's do a follow-up.
I'll commit this but leave it as "needs work" for that.
-
phenaproxima β
committed 6861cfbb on 1.x authored by
thejimbirch β
Issue #3493905 by thejimbirch, poker10, phenaproxima: Enable "Menu: Main...
-
phenaproxima β
committed 6861cfbb on 1.x authored by
thejimbirch β
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 1.x and cherry-picked to 1.0.x, but leaving at "needs work" for that follow-up.
-
phenaproxima β
committed 284bfd72 on 1.0.x authored by
thejimbirch β
Issue #3493905 by thejimbirch, poker10, phenaproxima: Enable "Menu: Main...
-
phenaproxima β
committed 284bfd72 on 1.0.x authored by
thejimbirch β
- πΈπ°Slovakia poker10
I have created a follow-up: π Add test for Sitemap module enabled plugins Active , so I suppose we can mark this one as Fixed?
Automatically closed - issue fixed for 2 weeks with no activity.