Language module is installed without default languages

Language was added to support the redirect module in this commit:

https://git.drupalcode.org/project/drupal_cms/-/commit/c2da73258577c6d93...

That's why it is in the base SEO recipe.

Redirect module doesn't depend on language module though.

My preference would be to remove it from SEO. I believe it was somewhat of a workaround for this optional config in Redirect: https://git.drupalcode.org/project/redirect/-/blob/8.x-1.x/config/option...

It doesn't depend on language officially but something something optional config and recipes.

I can see two solutions here, and they are both in the SEO recipe:

• We could import all of Language's config so that Redirect will be satisfied.
• We could remove the import of language.content_settings.redirect.redirect, which would compromise the translatability of redirects, but since we are shipping without multilingual support for now, that might make sense.

I favor the second option, but the final call belongs to @thejimbirch as the track lead.

So redirect is a content entity: https://git.drupalcode.org/project/redirect/-/blob/8.x-1.x/src/Entity/Re... the language settings for them are in redirect/config/optional/language.content_settings.redirect.redirect.yml.

However that is not required and would still be installed in Drupal CMS also if language module is installed later, due to how its named, no?

So I don't think it would compromise the translatability of redirects at all?

Re #3, we don't have the multilingual recipe in scope currently for 1.0, so there is no need to support that :) I think we'll face this soon again when we start adding multilingual recipe back after 1.0, and the solution will be different there.

However that is not required and would still be installed in Drupal CMS also if language module is installed later, due to how its named, no?

If the language module is installed later by a user in the UI, I believe you are correct.

When we created this recipe, we did have a multilingual recipe (from the prototype), and IIRC, we chicken and egg-ed language into the SEO recipe rather than have the multilingual require the redirect module.

Re #8 redirect/config/optional/language.content_settings.redirect.redirect.yml is a configuration entity and would need to be specifically imported in the future multilingual recipe. It would not automatically be imported.

I approve of removing it. Thanks for the MR.

I think that the removal of the Language module has changed (for the better!) the number of queries being checked by our performance test. Could you please adjust the failing assertion, @gábor hojtsy?

@phenaproxima: done, let's see.

Back to the land of happy commits.

Great collaboration in this issue. Merged into 1.x and cherry-picked to 1.0.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.