Contrib.social

Core's default content importer fumbles Experience Builder field data

Open on Drupal.org →
Created on 3 January 2025, 4 months ago

Overview

If you have a node, say, with some XB field data, and you export it with the contributed Default Content module, you'll get something like this for the XB field:

  components:
    -
      tree: '{"a548b48d-58a8-4077-aa04-da9405a6f418": []}'
      props: '{}'

If you try to import this using core's default content import service (\Drupal\Core\DefaultContent\Importer), you'll get an entity validation error:

components.0=The array must contain a "tree" key.||components.0=The array must contain a "props" key.

Before you ask, the problem is not some kind of mismatch between the contrib Default Content module and core's importer; core's importer was ported directly from the contrib module with few modifications. I know this because I wrote that patch.

The problem is that the importer sets each property of each field item. From \Drupal\Core\DefaultContent\Importer::setFieldValues() (abbreviated):

    foreach ($values as $delta => $item_value) {
      foreach ($item_value as $property_name => $value) {
        $property = $item->get($property_name);
        $property->setValue($value);
      }
    }

This is a reasonable thing for it to do. But XB's ComponentTreeItem doesn't really support this. You can only set the value as a whole if you want $this->values to be updated properly. That is also a reasonable thing to do, but this is a case where the legitimate assumptions of both projects end up conflicting, making everybody sad.

Proposed resolution

ComponentTreeItem::toArray() should not simply return $this->values, and neither should it delegate to the "magic" of Map::toArray(). Instead, it should return an explicit representation of its internal properties, rather than an unadorned copy of $this->values.

User interface changes

None.

🐛 Bug report
Status

Active

Version

0.0

Component

Data model

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024