Update move procedural hooks and mark as converted

I have created the patch please review it and let me know

We no longer use patches for core please convert your patch to an MR.

Also this is for the update module not node.

Further, we only need that attribute on the first non hook function.

I am working on this.

Looks straightforward enough to me. RTBC

@deepali sardana, please stop making patches. You’ve been told this on like 10 issues already. Yet every new issue you start working on you create a patch.

It doesn't look like we're actually converting anything here, right? We're just adding the attribute for when to stop scanning for procedural hooks in a bunch of files. Do we actually want to do some conversion, instead? Isn't that part of the fun of having split these out into smaller issues so we can make bigger changes where needed?

I'm not sure what you mean, all of the hooks that can be converted have been.

Unless you mean the non hooks, then I think that's a separate issue.

Sorry, totally missed. I had a stale copy of a branch checked out, and was only looking at the MR diff which seemed thin for some reason.

So we've already moved everything we can move, and converted everything to UpdateHooks, etc. The title here is kinda misleading. Maybe this is closer? I know you opened these issues in bulk with copy/pasta summaries and titles, but I think it's worth refining before it ends up in the Git history.

p.s. Saving credit to nicxvan for the MR, bramdriesen and myself for reviews, but not the patch in #3.

Thanks! Yeah this one was separate cause there were so many .inc files I wanted to take more time to review. Locale was in the same bucket.

Committed to 11.x - thanks!

larowlan → closed merge request !10673

Automatically closed - issue fixed for 2 weeks with no activity.