- Issue created by @jurgenhaas
-
jurgenhaas โ
committed 50d458d8 on 8.x-3.x
Issue #3495288 by jurgenhaas: Clean-up composer constraint for...
-
jurgenhaas โ
committed 50d458d8 on 8.x-3.x
-
jurgenhaas โ
committed 5a583500 on 4.0.x
Issue #3495288 by jurgenhaas: Clean-up composer constraint for...
-
jurgenhaas โ
committed 5a583500 on 4.0.x
- ๐จ๐ฆCanada joelpittet Vancouver
@jurgenhass thanks for fixing this I thought I needed to. I created this dupe ๐ Allow gin_toolbar 2.0 to install Active
Could you do a patch release when you get a chance? Thanks for updating this!
- ๐ฉ๐ชGermany jurgenhaas Gottmadingen
@joelpittet we didn't plan for a patch release because it doesn't really matter if you have gin_toolbar 1.0 or 2.0 because they are currently identical. Moving forward, 2.0 will progress and by then, a patch release will have been available if not earlier.
- ๐จ๐ฆCanada joelpittet Vancouver
Oh sorry, I was just trying to reproduce a bug but ran into this, if they are identical then yeah it doesnโt matter, sorry to bother. My bug was in environment_indicator in the end.
- ๐ฆ๐ทArgentina hanoii ๐ฆ๐ทUTC-3
I believe a patch release is still useful, to make things more future/proof.
i.e., I am running updates and happily update gin_toolbar to 4.0 but can't do 2.0 which I have to remember next batch of updates. I know it's a little thing, but so is releasing a patch release.
Just my 2c, congrats and thanks a lot!
- ๐ธ๐ฎSlovenia KlemenDEV
So this is fixed, but not released, right? Because I still can't update toolbar to 2.0 due to version constraints with Gin 4.0.0
- ๐ธ๐ฎSlovenia KlemenDEV
Thanks for the clarification and happy holidays!
- ๐ฉ๐ชGermany jurgenhaas Gottmadingen
As a reference also for others who come along and find this issue:
If you require
drupal/gin:^4
in your Drupal projects, that's sufficient, and you don't have to explicitly require the toolbar project. With composer, you get this automatically. For now, you still get version 1 of the toolbar, which is identical with version 2. So, nothing to worry about. As soon as there is a patch release of the Gin theme, the updated constraint will be delivered and that will then automatically update the toolbar to version 2. All this happens without the user/developer having to do anything. Automatically closed - issue fixed for 2 weeks with no activity.