[1.0.x] Language Roles

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. FILE: src/Access/ContentTranslationAccessCheck.php

  /**
   * AccessCheck constructor.
   */
  public function __construct(

FILE: src/Plugin/Field/FieldFormatter/LanguageRoleFormatter.php

  /**
   * {@inheritdoc}
   */
  public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, $label, $view_mode, array $third_party_settings, LanguageManagerInterface $language_manager, EntityTypeManagerInterface $entity_type_manager) {

FILE: src/Plugin/Field/FieldWidget/LanguageRoleWidget.php

  /**
   * Constructs the plugin instance.
   */
  public function __construct(

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

2. FILE: language_roles.module

/**
 * @file
 * language_roles.module
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

/**
 * Implements hook_ENTITY_TYPE_delete().
 */
function language_roles_user_delete($entity) {

/**
 * Implements hook_ENTITY_TYPE_delete().
 */
function language_roles_user_role_delete($entity) {

/**
 * Implements hook_ENTITY_TYPE_delete().
 */
function language_roles_configurable_language_delete($entity) {

The description for this hook should also say for which entity type this hook is implemented.

/**
 * Implements hook_form_FORM_ID_alter().
 */
function language_roles_form_language_content_settings_form_alter(&$form, $form_state, $form_id) {

The description for this hook should also say for which form this hook is implemented.

Thank you @vishal.kadam, those changes have been made. The hook_ENTITY_TYPE_delete functions were removed entirely as they were related to the previous implementation of storing languages/roles.

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.