Thank you @vishal.kadam, those changes have been made. The hook_ENTITY_TYPE_delete functions were removed entirely as they were related to the previous implementation of storing languages/roles.
heathstannard → created an issue.
Thank you, although the idea here would be to still make the module usable when content translation is not enabled. Language-based editing can still occur without needing translation.
I have adjusted the MR so that instead of adding the dependency, we're conditionally adding the service.
heathstannard → made their first commit to this issue’s fork.
Test in #5 was failing because of the bug in the dependency that we got fixed as part of https://www.drupal.org/project/warmer/issues/3309450 ✨ Drupal 10 Compatibility: Update module's info.yml file to reflect D10 compatibility, remove D8 Fixed . Have re-run the tests which are now passing. Any chance of a review on this issue?
PHP7.4 support has not been dropped, the composer require failure above is due to D10's requirement for PHP8.1.
I've added a test with PHP7.4 & D9.5 which passes.
I have followed up again on getting the dependency updated.
@e0ipso If we can't get any movement there, what would the recommended path forward be?
- Locking vipnytt/sitemapparser to 1.1.5 ?
- Forking that project and referencing the fork until we can get progress?
- Finding an alternative sitemap parser?
@heddn It's failing because of a bug introduced in the sitemap parser dependency. Once we get the dependency updated (https://github.com/VIPnytt/SitemapParser/pull/18) the test will pass.
heathstannard → made their first commit to this issue’s fork.