[Meta] Roadmap for Group 4.0.0

Hi!
Thanks a lot for the roadmap :)

Maybe Stop saving an entity when it gets added to a group is linked to #3057483 (core) 📌 [PP-2] Better describe how SynchronizableInterface should be used for content entities Needs work and/or #2872697 (group) → / #3478088 (group) 🐛 Group relationship saving/deletion resaves entities without using ::setSyncing() Active

Best

Uh yeah, there's an issue for that one already I just had to find it :) Thanks

I thought I saw that

Disallow automatic membership outside of form approach

already made it in. Can we confirm?

From Group:

  /**
   * {@inheritdoc}
   */
  public function postSave(EntityStorageInterface $storage, $update = TRUE) {
    parent::postSave($storage, $update);

    // If a new group is created and the group type is configured to grant group
    // creators a membership by default, add the creator as a member unless it
    // is being created using the wizard.
    // @todo Deprecate in 8.x-2.x in favor of a form-only approach. API-created
    //   groups should not get this functionality because it may create
    //   incomplete group memberships.
    $group_type = $this->getGroupType();
    if ($update === FALSE && $group_type->creatorGetsMembership() && !$group_type->creatorMustCompleteMembership()) {
      $values = ['group_roles' => $group_type->getCreatorRoleIds()];
      $this->addMember($this->getOwner(), $values);
    }
  }

I have opened https://www.drupal.org/project/group/issues/3494986 🐛 Review DI in classes and their construct methods Needs work to check the DI in controllers there (and maybe the __construct methods) :)

Best

Added to the list, along with "Drop constructor documentation and use property promotion where possible"

Added a kickass idea for a new editorial workflow

Great to see this Roadmap.

Some nice to have (if applicable):

1. Use SDC
2. Integrate a top level menu item into Navigation module (maybe this is done automatically)

Could look into SDC, is there an example of applying it to entities? I don't think I have anything else in my hook_theme. The permissions UI uses an inline template for some small things.

The top level menu thing we definitely need to look into for D11.

List is getting smaller :) Next one to tackle is probably the easy navigation entry and then "Disallow automatic membership outside of form approach". The brand-new creation UI I'm on the fence whether I want to add this now or at a later time. Still deciding...

Thinking of lifting the new editor flow where we use contexts into a minor release. Already getting rid of the wizard in the issue about not allowing automatic memberships outside of the form approach so that's one step in the right direction. Then 4.1 could contain more context provider support.