Group relationship saving/deletion resaves entities without using ::setSyncing()

Created on 1 October 2024, about 2 months ago

Problem/Motivation

We had a custom update that deleted and created multiple group memberships, and some additional custom code running on user save. This led to a very long running update because users are saved when memberships are created or deleted.

I checked git blame and this code was added to groups in 2016. I am guessing that with variation cache + cache tags that it should not be necessary to save entities any more, even if we possibly wanted to invalidate their cache tags 'just in case'.

However regardless of that, the code could definitely set the entities to syncing so that custom code can skip running certain things.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

2.3

Component

Code

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.

Merge Requests

!182Group relationship saving/deletion resaves entities without using ::setSyncing()
Open
🇬🇧United Kingdom catch
updated about 2 months ago

Comments & Activities

Issue created by @catch
Merge request !182Issue #3304728 by kristiaanvandeneynde: Add member page missing due to... → (Open) created by catch
Pipeline finished with Canceled
about 2 months ago
Total: 522s
#298238
Pipeline finished with Canceled
about 2 months ago
Total: 532s
#298240
Pipeline finished with Success
about 2 months ago
Total: 1034s
#298246
Comment about 1 month ago →
heddn Nicaragua
🐛 Node update hook is triggered upon group content create Needs work is related to this issue.
Comment 16 days ago →
🇩🇪Germany geek-merlin Freiburg, Germany
Postponing on the discussion in the other issue.
Comment 16 days ago →
🇩🇪Germany geek-merlin Freiburg, Germany
Postponed on the discussion in this issue.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024