[2.0.0-rc1] Remove TODOs and obsolete stuff

Mikael, can you have a look before Christian do it? (You may also take it if Christian is busy)

Can we also remove this from ComponentElementBuilder::buildProp() ?

    if (empty($data) && $prop_type->getPluginId() !== 'attributes') {
      // For JSON Schema validator, empty value is not the same as missing
      // value, and we want to prevent some of the prop types rules to be
      // applied on empty values: string pattern, string format, enum, number
      // min/max...
      // However, we don't remove empty attributes to avoid an error with
      // Drupal\Core\Template\TwigExtension::createAttribute() when themers
      // forget to use the default({}) filter.
      return $build;
    }

It looks like a security we may not need anymore

Mikael got a look, so back to Christian

christian.wiedemann → made their first commit to this issue’s fork.

I removed everything I was sure it doesn' break anything. For that reason I did not remove:

if (empty($data) && $prop_type->getPluginId() !== 'attributes') {
      // For JSON Schema validator, empty value is not the same as missing
      // value, and we want to prevent some of the prop types rules to be
      // applied on empty values: string pattern, string format, enum, number
      // min/max...
      // However, we don't remove empty attributes to avoid an error with
      // Drupal\Core\Template\TwigExtension::createAttribute() when themers
      // forget to use the default({}) filter.
      return $build;
    }

Where is the logic moved? I think we need it.

And we need also ui_patterns_field_config_delete. We could optimize the code and call the event inside the hook but it is a very little optimization so I decided to let it as it is.

Let's create an other ticket for this specific empty($data) && $prop_type->getPluginId() !== 'attributes') issue.

If everything else is done (or skipped because considered unsafe) you can give the current ticket to Mikael for review

looks ok for merge. then i just rebased to prepare merge

Automatically closed - issue fixed for 2 weeks with no activity.