[2.0.0-rc1] Remove temporary compatibilty layers

2 feedbacks

Remove the merge logic from stories

You removed the call to ::mergeStories() without replacing it by StoryPluginManager::getComponentStories() :

-    // ::mergeStories() is a temporary compatibility layer.
-    // @todo Replace by StoryPluginManager::getComponentStories() before 2.0.0
-    // release.
-    $component = $this->storyPluginManager->mergeStories($component['id'], $component);

So, I am afraid it is not working well. Did you test by looking the component library?

What else?

Do you know any other similar compatibility layers to remove? I am not sure I was thinking about everything while authoring this ticket.

ah sorry, missunderstood the comment. I just opend the library but there are no stories inside the ui patterns in any test module. A test module would be great and some render tests.

Here is my list what we should change:

• Move this hook function ui_patterns_field_config_delete(FieldConfigInterface $field_config): void TO ::UiPatternsEntitySchemaSubscriber
• Remove ui_patterns_plugin_filter_block__ui_patterns_alter
• Remove ui_patterns_test_theme. I think we don't need it anymore
• Remove test components alert, close_button, prop_types_tests
• Remove ui-patterns-actions.html.twig
• Not sure about ui_patterns_legacy.
• Not sure about ui_patterns_blocks.
• Not sure about ui_patterns_field_formatters.

I just opend the library but there are no stories inside the ui patterns in any test module.

Maybe because you wrote

$component = $this->storyPluginManager->getComponentStories($component['id']);

Instead of:

$component['stories] = $this->storyPluginManager->getComponentStories($component['id']);


now I got it :) Mostly it is better to understand before deleting stuff:). But do you have a sample story format that I can ready test it. Inside the ui_patterns there is no sample or test component or?

Maybe we discuss this issue on thursday together with Mikael.

Careful, I have rebased your MR. It looks mergeable to me.

But do you have a sample story format that I can ready test it.

I usually test with public implementations:

• https://git.drupalcode.org/project/ui_suite_bootstrap/-/tree/5.1.x/compo...
• https://git.drupalcode.org/project/ui_suite_daisyui/-/tree/4.0.x/components

You kept the issue on your side, you want to test before merging?

Here is my list what we should change:

• Move this hook function ui_patterns_field_config_delete(FieldConfigInterface $field_config): void TO ::UiPatternsEntitySchemaSubscriber
• Remove ui_patterns_plugin_filter_block__ui_patterns_alter
• Remove ui_patterns_test_theme. I think we don't need it anymore
• Remove test components alert, close_button, prop_types_tests
• Remove ui-patterns-actions.html.twig
• Not sure about ui_patterns_legacy.
• Not sure about ui_patterns_blocks.
• Not sure about ui_patterns_field_formatters.

That's great, thanks, I will create a dedicated issue.

It would be nice to add an automatic test

you mean adding an automatic test for stories? or which test(s)?

Those tests belongs to ui_patterns_library

i don't know why it's for me, i send it back to christian :)

Auto merge

Automatically closed - issue fixed for 2 weeks with no activity.