Document webform_bootstrap deprecation

Created on 10 December 2024, 6 months ago

Problem/Motivation

Sub-module webform_bootstrap was deprecated in the parent issue. The deprecation links to What to do about deprecated external libraries in Webform 6.x+ , but this page does not mention Bootstrap.

Proposed resolution

Add documentation explaining the deprecation.

Remaining tasks

Write documentation.

User interface changes

None.

API changes

None.

Data model changes

None.

📌 Task
Status

Active

Version

6.3

Component

Documentation

Created by

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Liam Morland
  • 🇺🇸United States jrockowitz Brooklyn, NY

    We could also move this code to the webform_deprecated project.

  • 🇺🇸United States jrockowitz Brooklyn, NY

    I am realizing that Bootstrap 3.x is still supported. We can keep the code deprecated in the core webform module but tweak the webform_bootstrap.module to only work with Bootstrap 3.x.

  • 🇺🇸United States jrockowitz Brooklyn, NY

    I think can we assume no one is creating new sites with Bootstrap 3.x, and we should remove the Bootstrap check in hook_requirements. This will allow us to move the webform_bootstrap.module to https://www.drupal.org/project/webform_deprecated .

  • 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    Makes sense.

  • Pipeline finished with Success
    6 months ago
    Total: 722s
    #368008
  • Pipeline finished with Skipped
    6 months ago
    #368029
    • c1014a61 committed on 6.3.x
      Issue #3492971: Document webform_bootstrap deprecation
      
  • 🇺🇸United States jrockowitz Brooklyn, NY
    • c1014a61 committed on 6.x
      Issue #3492971: Document webform_bootstrap deprecation
      
  • 🇨🇦Canada joseph.olstad

    I'm creating new bootstrap 3 sites including one I just created this week.

  • 🇨🇦Canada joseph.olstad

    Bootstrap 3.34 is compatible with Drupal 11 and there's no plans to stop at 11.

    Drupal 11 is currently planned to be supported until December 2027

  • 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    I think support for things like Bootstrap should be in separate projects. There is already webform_bootstrap5 .

  • 🇨🇦Canada joseph.olstad

    ok so basically fork webform_bootstrap into a seperate contrib project, this works for you?

  • 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    I would be fine with that.

  • 🇺🇸United States jrockowitz Brooklyn, NY

    I am okay with someone creating and maintaining a dedicated webform_bootstrap project.

  • Pipeline finished with Failed
    5 months ago
    Total: 746s
    #403599
  • Pipeline finished with Failed
    5 months ago
    Total: 1115s
    #403704
  • Pipeline finished with Failed
    5 months ago
    Total: 1031s
    #403736
  • Pipeline finished with Failed
    4 months ago
    Total: 849s
    #403930
  • Pipeline finished with Success
    4 months ago
    Total: 862s
    #404006
  • Pipeline finished with Success
    4 months ago
    Total: 864s
    #404019
  • Pipeline finished with Success
    4 months ago
    Total: 863s
    #404519
  • Pipeline finished with Success
    4 months ago
    Total: 1079s
    #404583
  • Pipeline finished with Canceled
    4 months ago
    Total: 752s
    #404600
  • Pipeline finished with Canceled
    4 months ago
    Total: 346s
    #404606
  • Pipeline finished with Canceled
    4 months ago
    Total: 160s
    #404608
  • Pipeline finished with Skipped
    4 months ago
    #404619
  • Pipeline finished with Success
    4 months ago
    Total: 869s
    #404610
  • Status changed to Needs review 4 months ago
  • 🇮🇷Iran amir jamshidi

    Hello every one.

    I installed the https://www.drupal.org/project/bootstrap/releases/8.x-3.35 template but now I have this error

    Unable to install theme: 'bootstrap' due to unmet module dependencies: 'jquery_ui_draggable, jquery_ui_resizable'.

  • 🇺🇸United States yesct

    This doesn't seem like a release blocker to me. (Just noting.) Priority normal seems fine to me also.

  • 🇺🇸United States jrockowitz Brooklyn, NY

    I think we need to fork the webform bootstrap 3 module into a dedicated project and deprecate the code in the webform module.

  • 🇺🇸United States yospyn

    Hi - I work on a Drupal 10.4.5 site that's been using Bootstrap 3 for a long time and here's what I observed:

    - Upgraded to 6.3@beta from 6.2.9, webforms appear normal with webform_bootstrap still installed
    - Uninstalled webform_bootstrap (since deprecated) and webform styling gets a little wacky

    Thus, for the moment, I'm not uninstalling webform_bootstrap on production. So it would be great to have this submodule still available in some way.

  • 🇨🇦Canada joseph.olstad

    @yospyn, we're using webform_bootstrap with Drupal 11.1.6 and the latest webform module 6.3.0-beta2.

    As for deprecating, I think it's too soon to deprecate. Bootstrap 3 will be supported for the duration of jQuery 4 and possibly beyond. There's tens of thousands of installs.

    with that said, could fork if needed as mentioned earlier.

  • 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    The best thing would be to create a separate webform_bootstrap module project.

  • 🇨🇦Canada joseph.olstad

    @liam morland, forking is problematic for a few reasons, mainly the bumpy ride for existing installs and it's not going to be something that automatically happens for those upgrading. People will stumble before they find the solution.

  • Pipeline finished with Success
    about 1 month ago
    #488985
  • Pipeline finished with Success
    about 1 month ago
    #488991
Production build 0.71.5 2024