- Issue created by @pameeela
- πͺπΈSpain ckrina Barcelona
This is ready to be worked on since the designs are finished in π Create designs for Project & Case Study content types within Olivero Active .
- π¬π§United Kingdom tonypaulbarker Leeds
I am figuring out the hero image styles across the content types at https://www.drupal.org/project/drupal_cms/issues/3495584 π Implement hero images to match designs Active
and the classes to set the content widths of the node content across the content types at https://www.drupal.org/project/drupal_cms/issues/3495583 π Implement full node content widths to match designs Active
- First commit to issue fork.
- πΊπΈUnited States mherchel Gainesville, FL, US
Styles and recipe updates. Should be good to go.
- πΊπΈUnited States phenaproxima Massachusetts
Sending to @pameeela for review and assigning credit.
- π¬π§United Kingdom tonypaulbarker Leeds
The logo looks likely to be above the fold according to the design so it should probably have eager loading?
- π¦πΊAustralia pameeela
Case study looked good, thanks @mherchel! I've applied the same to project and made some other minor tweaks to align the config of the two content types with each other.
Could use a sanity check from someone else that I didn't miss anything.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I scanned the code changes and nothing jumped out at me except a minor formatting nitpick that doesn't matter. I'll try testing now.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Here's my attempt at recreating the case study.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Some feedback for the case study:
- The link in Figma is at top but it showed up on the bottom for testing
- When including the client name, it shows up below the logo but I didn't see it shown in Figma
I'll see if there's anything else.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
How the client name shows up. I'm wondering if the text was supposed to the styled text next to the logo?
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Note that the link was moved to the bottom in a subsequent design:
https://www.figma.com/design/Ybs8y4FQbHUiFw2ioYf5nc/Olivero-for-Drupal-C...
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Chatted with Pamela and we'll get this in as is and I'll create a follow-up issue to fix the logo+client name placement.
Before I do that, I will double check that the project content type is working the same way.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Here's the project page:
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
The two remaining things for the follow-up issue:
- Alignment of client logo and name
- Spacing around link is too much
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Follow-up issue:
π Project and case study full page display CSS tweaks Active
- πΊπΈUnited States phenaproxima Massachusetts
Applied one suggestion to fix a nitpick, but it looks a few oddities snuck in (to the code) that shouldn't be there?
- πΊπΈUnited States phenaproxima Massachusetts
Fixed the accidental cross-component dependency introduced by having the Redirect module enabled. If it passes tests, I'm merging it.
-
phenaproxima β
committed dd1b65f4 on 1.x authored by
mherchel β
Issue #3491813 by pameeela, mherchel, phenaproxima, kristen pol,...
-
phenaproxima β
committed dd1b65f4 on 1.x authored by
mherchel β
-
phenaproxima β
committed 2b81f690 on 1.0.x authored by
mherchel β
Issue #3491813 by pameeela, mherchel, phenaproxima, kristen pol,...
-
phenaproxima β
committed 2b81f690 on 1.0.x authored by
mherchel β
- πΊπΈUnited States phenaproxima Massachusetts
The regression tests passed and I have complete confidence the rest will too. It's getting late here and I don't feel like slogging through a multitude of random test failures thanks to the MySQL containers being π©.
So with all that in mind...merged into 1.x and cherry-picked to 1.0.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.