- Issue created by @longwave
- 🇬🇧United Kingdom longwave UK
This has a new requirement for a license key. We can default it to "GPL" but https://www.drupal.org/project/ckeditor5_premium_features → also wants to set this so we should ensure that is still possible.
- 🇳🇱Netherlands spokje
Code changes seem fine an GitLab loves them.
This has a new requirement for a license key. We can default it to "GPL" but https://www.drupal.org/project/ckeditor5_premium_features → also wants to set this so we should ensure that is still possible.
Not too sure if we're supposed to this this here or in the contrib queue for ckeditor5_premium_features ?
- 🇬🇧United Kingdom longwave UK
We need to set
GPL
here or CKEditor5 fails to initialize with "license-key-missing": https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#erro...The code is designed to allow any plugin to set
licenseKey
and only set it as a last resort, I haven't manually tested with the Premium Features module though. - 🇳🇱Netherlands spokje
@longwave, Ah, I seee, thanks for explaining.
We _could_ open an issue in their queue and wait for confirmation, we could test it ourselves or we could just steamroll ahead.
First option is probably going to taken longer than the window we have before 11.1.0 gets shipped, option #2 is for the nice people out there.
Sadly I'm not one of those, going to mark this RTBC to get this in 11(.1).x ASAP (10.4/5 seem to have a broken HEAD) and move one.The ~12.000 install aren't going to jump to 11.1.0 immediately, so if things go wrong with the key, there's time to fix it.
- 🇵🇱Poland salmonek
Hey, I already tested the update with Premium Features and Plugin Pack's Templates.
Recent versions of both modules are working fine with this update. - 🇳🇱Netherlands spokje
Thanks @salmonek, for both being a nice person and reporting back :)
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.1.x, thanks!
Moving to 10.4.x for backport.
- 🇳🇱Netherlands spokje
@smustgrave Are you sure? I see a fully green pipeline on this MR: https://git.drupalcode.org/project/drupal/-/pipelines/359531
- 🇺🇸United States smustgrave
Weird definitely when I opened it almost all functional tests were failing + nightwatch but yea it's green again.
- 🇬🇧United Kingdom longwave UK
Some tests are being super flaky at the moment, not sure why.
-
longwave →
committed a026efe5 on 10.4.x
Issue #3491464 by longwave, spokje, salmonek, catch: Update CKEditor 5...
-
longwave →
committed a026efe5 on 10.4.x
-
longwave →
committed 8bdb090a on 10.5.x
Issue #3491464 by longwave, spokje, salmonek, catch: Update CKEditor 5...
-
longwave →
committed 8bdb090a on 10.5.x
- 🇬🇧United Kingdom longwave UK
Committed and pushed 8bdb090a3db to 10.5.x and a026efe5199 to 10.4.x. Thanks!