- Issue created by @pameeela
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Going to review and test.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I re-read the text many times, and it seems fine. I changed a couple of nitpicks.
I ran through the instructions with the dev zip file and it worked fine with ddev version v1.24.1.
I had previously had an error with rc2 and ddev version v1.23.4 (had to upgrade ddev), but @phenaproxima says that's been fixed in dev and it was painful to try to revert my ddev so I didn't test that. Hopefully this is fine.
Note, that I did get a ddev error because I had previously installed rc2 and needed to remove my older install. This error could be added to the general docs in a troubleshooting section, so I pinged Suzanne in case it should be.
Other than that, the only "warnings" were:
Unable to set permissions inside container on settings files: ''
on the command line which doesn't have an issue...
... and many "block plugin not found" logs (about 50 of them):
π Block plugin not found warnings on install Active
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Content in the readme looks great. Thanks for the edits @kristen pol
Marking as RTBC
- πΊπΈUnited States phenaproxima Massachusetts
I'd like final sign-off from Pam on this one.
- π¦πΊAustralia pameeela
Should we wait until we have docs to link to? I don't want to release with 'Coming soon'. But can do that in a follow up?
-
phenaproxima β
committed 18fe9666 on 1.x
Issue #3491189 by kristen pol, phenaproxima, thejimbirch, pameeela:...
-
phenaproxima β
committed 18fe9666 on 1.x
-
phenaproxima β
committed a7adb89a on 1.0.x
Issue #3491189 by kristen pol, phenaproxima, thejimbirch, pameeela:...
-
phenaproxima β
committed a7adb89a on 1.0.x
- πΊπΈUnited States phenaproxima Massachusetts
Yep, that's definitely follow-up stuff. Worst case scenario, we rip that section out of the README. Merged into 1.x and cherry-picked to 1.0.x. Thanks for the review!
Automatically closed - issue fixed for 2 weeks with no activity.