Contrib.social

Add array return to all hook_jsonapi_ENTITY_TYPE_filter_access hook implementations

Open on Drupal.org →
Created on 2 December 2024, 4 months ago

Problem/Motivation

See 📌 [META] Add return types to hook implementations Active

Steps to reproduce

grep -P "Method Drupal\\\\\\\\.*jsonapi.*FilterAccess.* has no return type specified" core/.phpstan-baseline.php

Proposed resolution

Add : array to hook_jsonapi_ENTITY_TYPE_filter_access in jsonapi.php

Add : array to the following:

Drupal\jsonapi\Hook\JsonapiHooks::jsonapiBlockContentFilterAccess()
Drupal\jsonapi\Hook\JsonapiHooks::jsonapiCommentFilterAccess()
Drupal\jsonapi\Hook\JsonapiHooks::jsonapiEntityFilterAccess()
Drupal\jsonapi\Hook\JsonapiHooks::jsonapiEntityTestFilterAccess()
Drupal\jsonapi\Hook\JsonapiHooks::jsonapiFileFilterAccess()
Drupal\jsonapi\Hook\JsonapiHooks::jsonapiMediaFilterAccess()
Drupal\jsonapi\Hook\JsonapiHooks::jsonapiNodeFilterAccess()
Drupal\jsonapi\Hook\JsonapiHooks::jsonapiShortcutFilterAccess()
Drupal\jsonapi\Hook\JsonapiHooks::jsonapiTaxonomyTermFilterAccess()
Drupal\jsonapi\Hook\JsonapiHooks::jsonapiUserFilterAccess()
Drupal\jsonapi\Hook\JsonapiHooks::jsonapiWorkspaceFilterAccess()

Update phpstan baseline

Remaining tasks

Recommended to only pick up this ticket if you will do all 3 steps in proposed resolution.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

jsonapi.module

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024