- Issue created by @mstrelan
- Merge request !10445Issue #3490954: Added return types to functions and updated .phpstan-baseline.php → (Closed) created by nexusnovaz
- 🇬🇧United Kingdom nexusnovaz
Running the grep command, there was only 20 functions. I've updated those and pushed my changed. Please can you review MR !10445
- 🇦🇺Australia mstrelan
Checked again and there are only 20, not 44, ever since 📌 Add return types to update_test_* hooks Active . Have updated the IS to reflect that.
MR looks good, pipeline is green, 120 lines removed from baseline checks out (20 x 6 = 120). RTBC from me.
-
quietone →
committed 4e64f397 on 11.1.x
Issue #3490954 by nexusnovaz, mstrelan: Add return types to...
-
quietone →
committed 4e64f397 on 11.1.x
-
quietone →
committed 671996fd on 11.x
Issue #3490954 by nexusnovaz, mstrelan: Add return types to...
-
quietone →
committed 671996fd on 11.x
- 🇳🇿New Zealand quietone
That equivalent_update_test_update_100201 returns TranslatableMarkup is unusual but it is part of the testing.
Committed to 11.x and cherry-picked to 11.1.x
Thanks
Automatically closed - issue fixed for 2 weeks with no activity.