- Issue created by @nicxvan
- πΊπΈUnited States smustgrave
Think the CR should be updated with some code examples
Also some test coverage for the hooks to show they work.
- πΊπΈUnited States smustgrave
I don't think we need to convert all here but could we convert least 1-2 instances to use this new hook. With the test coverage I do believe it's working but it being used live would be great.
- πΊπΈUnited States smustgrave
Appears to have a pipeline issue. But keeping an eye out for this one.
- πΊπΈUnited States smustgrave
Thanks for adding that example!
Rest looks good to me
- πΊπΈUnited States dww
Thanks for this! Exciting.
Iβm only looking at the MR on my phone. I have some concerns. Iβll post a thorough review later when Iβm not thumb-typing.π But I donβt believe this is totally ready in its current state. No rush, since this isnβt happening for 11.1.x. But getting out of the RTBC queue for now so committers donβt waste time on it.
- πΊπΈUnited States dww
Or I guess to make @smustgrave happy, NW is better. π Sorry to change the status to that without explanation, but Iβll open MR threads later with details.
- π¬π§United Kingdom alexpott πͺπΊπ
I'm not sure about the decisions that are creating this API. It feels like the question is how can we make this an OOP hook - and not what is the correct API for gathering requirements during install, update and runtime. The solution being advocated for in this and the other issues feels just asking ourselves what is possible with OOP hooks - and not what it is the correct API for gathering requirements from modules.