- Issue created by @mstrelan
- š®š³India hetal.solanki
@mstrelan
MR looks good moving to RTBC.
Thank You!!
- First commit to issue fork.
- š®š³India shalini_jha
Rebased this and resolved conflicts. However, after running the command:
grep "_requirements\\\\.* has no return type specified" core/.phpstan-baseline.phpI noticed that two additional entries are still listed:
'message' => '#^Function install_check_requirements\\(\\) has no return type specified\\.$#', 'message' => '#^Function update_check_requirements\\(\\) has no return type specified\\.$#',
Iām unsure if we also need to update these?
- šŗšøUnited States nicxvan
No, those are not hooks, they cannot be updated here.
- š®š³India shalini_jha
Thank you for the confirmation. Since everything is addressed, I am moving this to Needs Review.
- šØšSwitzerland berdir Switzerland
Is it really worth doing this when we are in the middle of changing all hook_requirements() implementations anyway?
- šŗšøUnited States nicxvan
Sure why not, we did it for all of the other hooks, at the minimum it means you don't have to manage phpstan when converting them which is nice.
-
quietone ā
committed a0503e22 on 11.x
Issue #3498059 by mstrelan, shalini_jha, hetal.solanki: Add array return...
-
quietone ā
committed a0503e22 on 11.x
- š³šæNew Zealand quietone
Applied the diff and regenerated the baseline. That results in finding 2 instances but they are not hooks.
(11.x)$ grep "_requirements\\\\.* has no return type specified" core/.phpstan-baseline.php 'message' => '#^Function install_check_requirements\\(\\) has no return type specified\\.$#', 'message' => '#^Function update_check_requirements\\(\\) has no return type specified\\.$#',