Create class to replace hook_update_requirements

Adding tests

Test added

The issue summary here is missing the why we should do this. What is wrong with the old system of using $phase. If the answer is the hook system updates to be OOP - then I'm not sure that we're thinking about this the right way around.

The short answer is the different phases have different requirements for what can be injected. Also almost all modules only interact with one phase so this would be a clean move.

I'll reply more fully on the meta.

Marking this postponed since an alternate approach was suggested in the Meta

Thanks for moving this forward. The parent meta has good discussion on why this is actually the right approach, after all. 😅

Left a bunch of suggestions on the MR. Mostly pedantic nits, but a few things of substance.

I applied all suggestions, I'll take care of the last suggestion tomorrow, thanks!

Fixed last couple of comments!

Left some comments. But think if we can see some phpcs violations we should try and address in the issue.

Phpstan different animal and agree breaking that out.

Took care of it here and the other one too.

Thanks, believe feedback has been addressed

Whoops cross posted.

Apologies, I missed a point in my previous feedback on the API docs.

nicxvan → changed the visibility of the branch 3490841-create-hookruntimerequirements to hidden.

I have a very minor lingering concern that INFO and OK are weird for update. They’re never displayed unless there’s an error or warning, in which case all update requirements, even OK and INFO, are shown to the user, distracting them from the thing they actually have to fix. 😕 This is not a problem to be solved in this issue. 😅 Maybe some of it can be addressed at 📌 Deprecate REQUIREMENT_INFO in favor of REQUIREMENT_OK Active , but probably we’ll want yet another follow up for the UX of update.php when there are requirements problems.

That said, I think we’ve done everything we can to make this a clean and solid improvement. RTBC!

Thanks,
-Derek

Minor formatting for title and summary.

nicxvan → changed the visibility of the branch 11.x to hidden.

Committed 8798285 and pushed to 11.x. Thanks!

quietone → closed merge request !10411

Automatically closed - issue fixed for 2 weeks with no activity.