Issues reported by phpcs

$ vendor/bin/phpcs -s $_WEB_ROOT/modules/custom --report-junit=junit.xml --report-full --report-summary --report-source $_PHPCS_EXTRA FILE: ...oject/charts/web/modules/custom/charts/tests/src/Kernel/DimensionsTest.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE -------------------------------------------------------------------------------- 32 | ERROR | [x] Parameter $expected_width has null default value, but is not | | marked as nullable. | | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing) 32 | ERROR | [x] Parameter $expected_height has null default value, but is not | | marked as nullable. | | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...es/custom/charts/tests/src/FunctionalJavascript/DataCollectorTableTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is | | Drupal\Core\StringTranslation\StringTranslationTrait. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...s/tests/modules/charts_test/src/Plugin/chart/Library/ChartsTestLibrary.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\Html. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /builds/project/charts/web/modules/custom/charts/src/TypeManager.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is | | Drupal\Component\Plugin\Exception\PluginException. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /builds/project/charts/web/modules/custom/charts/src/Util/Util.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 29 | ERROR | [x] Parameter $view has null default value, but is not marked as | | nullable. | | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...eb/modules/custom/charts/src/Plugin/views/style/ChartsPluginStyleChart.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Serialization\Json. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...t/charts/web/modules/custom/charts/src/Plugin/views/field/ScatterField.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Serialization\Json. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...arts/web/modules/custom/charts/src/Plugin/views/field/ExposedChartType.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Form\FormStateInterface. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ct/charts/web/modules/custom/charts/src/Plugin/views/field/BubbleField.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Serialization\Json. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...charts/src/Plugin/Field/FieldFormatter/ChartConfigItemDefaultFormatter.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\Html. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...lds/project/charts/web/modules/custom/charts/src/Form/ChartsConfigForm.php -------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Serialization\Yaml. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) 68 | ERROR | [x] Parameter $chart_plugin_manager has null default value, but | | is not marked as nullable. | | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing) 68 | ERROR | [x] Parameter $chart_type_plugin_manager has null default value, | | but is not marked as nullable. | | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing) 68 | ERROR | [x] Parameter $module_extension_list has null default value, but | | is not marked as nullable. | | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...s/web/modules/custom/charts/src/EventSubscriber/ConfigImportSubscriber.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Config\ConfigEvents. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...t/charts/web/modules/custom/charts/src/Element/ChartDataCollectorTable.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\Environment. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /builds/project/charts/web/modules/custom/charts/src/Element/Chart.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Serialization\Json. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ilds/project/charts/web/modules/custom/charts/src/Element/BaseSettings.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\Html. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...m/charts/modules/charts_highcharts/src/Plugin/chart/Library/Highcharts.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\Html. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...es/custom/charts/modules/charts_google/src/Plugin/chart/Library/Google.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\Html. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...s/custom/charts/modules/charts_chartjs/tests/src/Kernel/DimensionsTest.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE -------------------------------------------------------------------------------- 34 | ERROR | [x] Parameter $expected_width has null default value, but is not | | marked as nullable. | | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing) 34 | ERROR | [x] Parameter $expected_height has null default value, but is not | | marked as nullable. | | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: .../custom/charts/modules/charts_chartjs/src/Plugin/chart/Library/Chartjs.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\Color. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) 209 | ERROR | [x] Expected one space after the comma, 0 found | | (Drupal.WhiteSpace.Comma.NoSpace) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...eb/modules/custom/charts/modules/charts_c3/src/Plugin/chart/Library/C3.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\Html. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...dules/custom/charts/modules/charts_blocks/src/Plugin/Block/ChartsBlock.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\NestedArray. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...tom/charts/modules/charts_billboard/src/Plugin/chart/Library/Billboard.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\Html. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /builds/project/charts/web/modules/custom/charts/charts.post_update.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Serialization\Yaml. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 1.31 secs; Memory: 18MB PHP CODE SNIFFER REPORT SUMMARY -------------------------------------------------------------------------------- FILE ERRORS WARNINGS -------------------------------------------------------------------------------- ...ect/charts/web/modules/custom/charts/charts.post_update.php 1 0 ...les/charts_billboard/src/Plugin/chart/Library/Billboard.php 1 0 ...arts/modules/charts_blocks/src/Plugin/Block/ChartsBlock.php 1 0 ...om/charts/modules/charts_c3/src/Plugin/chart/Library/C3.php 1 0 ...modules/charts_chartjs/src/Plugin/chart/Library/Chartjs.php 2 0 .../modules/charts_chartjs/tests/src/Kernel/DimensionsTest.php 2 0 ...s/modules/charts_google/src/Plugin/chart/Library/Google.php 1 0 ...s/charts_highcharts/src/Plugin/chart/Library/Highcharts.php 1 0 ...roject/charts/web/modules/custom/charts/src/TypeManager.php 1 0 ...arts/web/modules/custom/charts/src/Element/BaseSettings.php 1 0 ...ject/charts/web/modules/custom/charts/src/Element/Chart.php 1 0 ...dules/custom/charts/src/Element/ChartDataCollectorTable.php 1 0 ...ustom/charts/src/EventSubscriber/ConfigImportSubscriber.php 1 0 ...rts/web/modules/custom/charts/src/Form/ChartsConfigForm.php 4 0 ...in/Field/FieldFormatter/ChartConfigItemDefaultFormatter.php 1 0 ...odules/custom/charts/src/Plugin/views/field/BubbleField.php 1 0 ...s/custom/charts/src/Plugin/views/field/ExposedChartType.php 1 0 ...dules/custom/charts/src/Plugin/views/field/ScatterField.php 1 0 ...om/charts/src/Plugin/views/style/ChartsPluginStyleChart.php 1 0 .../project/charts/web/modules/custom/charts/src/Util/Util.php 1 0 .../charts_test/src/Plugin/chart/Library/ChartsTestLibrary.php 1 0 ...s/tests/src/FunctionalJavascript/DataCollectorTableTest.php 1 0 ...b/modules/custom/charts/tests/src/Kernel/DimensionsTest.php 2 0 -------------------------------------------------------------------------------- A TOTAL OF 29 ERRORS AND 0 WARNINGS WERE FOUND IN 75 FILES -------------------------------------------------------------------------------- PHPCBF CAN FIX 29 OF THESE SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- PHP CODE SNIFFER VIOLATION SOURCE SUMMARY -------------------------------------------------------------------------------- SOURCE COUNT -------------------------------------------------------------------------------- [x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.Incorrectl 20 [x] SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.Null 8 [x] Drupal.WhiteSpace.Comma.NoSpace 1 -------------------------------------------------------------------------------- A TOTAL OF 29 SNIFF VIOLATIONS WERE FOUND IN 3 SOURCES -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SOURCES AUTOMATICALLY (29 VIOLATIONS IN TOTAL) --------------------------------------------------------------------------------

Comments & Activities

Issue created by @bluegeek9
Merge request !117Issue #3490680 by bluegeek9: Issues reported by phpcs → (Merged) created by bluegeek9
Pipeline finished with Success
2 months ago
Total: 295s
#354364
Comment 2 months ago →
🇺🇸United States bluegeek9
The phpcs job passes green in the pipeline.

https://git.drupalcode.org/issue/charts-3490680/-/jobs/3535564
Pipeline finished with Success
about 2 months ago
Total: 215s
#357852
Pipeline finished with Success
about 2 months ago
Total: 157s
#357947
Pipeline finished with Success
about 2 months ago
Total: 154s
#358202
Comment about 2 months ago →
🇨🇦Canada nikathone Ontario
Pipeline finished with Skipped
about 2 months ago
#365056
First commit to issue fork.
Comment about 2 months ago →
System Message

andileco → committed bc350175 on 5.1.x authored by bluegeek9 →
Issue #3490680 by bluegeek9: Issues reported by phpcs
Comment about 2 months ago →
🇺🇸United States andileco
Comment about 1 month ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!117Issues reported by phpcs
Merged

Comments & Activities

Issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!117Issues reported by phpcsMerged

Comments & Activities

!117Issues reported by phpcs
Merged