- Issue created by @dinarcon
- First commit to issue fork.
- 🇮🇳India akulsaxena
Hi
I have added the LICENSE.txt file as requested
The PHPCS and cspell pipelines are failing but an issue 📌 Fix cspell and phpcs issues Active has already been created for the same.
Please review and merge - First commit to issue fork.
- 🇮🇳India akulsaxena
Hi @jvbrian
I already generated the MR and made the necessary changes.
The issue was already in Needs Review state.
All you have done is add two spaces extra in 2 different files, which is actually not required.
Please ensure if the issue you pick is already assigned to someone or is in needs review state and the work is complete, you should not work on it until it moves back to needs work state and is unassigned. - 🇳🇮Nicaragua dinarcon
Thanks for working on this @akulsaxena
Hi @jvbrian It is indeed strange to add the spaces to those files when such change is not necessary. The current status of the issue is
Needs Review
. Can you verify that the necessary changes, as instructed in the issue summary, have been implemented? And if so, can you add a comment indicating you have reviewed the issue and change the issue status toReviewed & tested by the community
(RTBC)?I have rebased the MR after 📌 Fix cspell and phpcs issues Active The pipelines are already passing.
- 🇮🇳India akulsaxena
@jvbrian
Will you be reviewing this? The licence file has been added and the required code for the same is already present in the composer.json file. Let me know if you find any other issue otherwise this can be set to RTBC and then merged. Hey, I reviewed the MR and the changes look good enough
The license file was added and composer.json has the required license information
Pipelines are all green.
Moving it to RTBC
Thanks-
dinarcon →
committed 57da51d5 on 1.0.x authored by
akulsaxena →
Issue #3490571 by akulsaxena, dinarcon, dhruv.mittal: Add license file
-
dinarcon →
committed 57da51d5 on 1.0.x authored by
akulsaxena →
- 🇳🇮Nicaragua dinarcon
Thanks for working on this @akulsaxena and for your review @dhruv.mittal
Automatically closed - issue fixed for 2 weeks with no activity.