- Issue created by @joelpittet
- 🇨🇦Canada joelpittet Vancouver
joelpittet → changed the visibility of the branch 3489748-fix-and-require to hidden.
- 🇨🇦Canada joelpittet Vancouver
joelpittet → changed the visibility of the branch 8.x-1.x to hidden.
- 🇮🇳India lavanyatalwar
Hi @joelpittet,
In the file calendar-overlap.css, there are some classes where no CSS is being applied. Should I remove them?.calendar-calendar .day-view .full td.multi-day .calendar.dayview .contents div, .calendar-calendar .week-view .full td.multi-day .calendar.weekview .contents div { }
Also in calender.css
/* Item styles */ .calendar-pager__item {} /* Current page indicator */ .pager__item--current {} .calendar-pager__item-title--backwards {} .calendar-pager__item-title--forward {}
- 🇮🇳India lavanyatalwar
@joelpittet, I fixed all the stylelint errors except for the empty CSS blocks with no styling.
- 🇨🇦Canada joelpittet Vancouver
@lavanyatalwar That is great, yeah leave those, is there a way in style lint to explicitly ignore like phpcs:ignore? I'd also be happy to have them moved to a comment, as they are only there to document what is at your disposal
- 🇮🇳India lavanyatalwar
@joelpittet, The pipeline is green now.
Kindly check and merge :) -
joelpittet →
committed d5842542 on 8.x-1.x
Resolve #3489748 "Stylelint"
-
joelpittet →
committed d5842542 on 8.x-1.x
- 🇨🇦Canada joelpittet Vancouver
Thanks again @lavanyatalwar I have merged the MR.
Automatically closed - issue fixed for 2 weeks with no activity.