Create a way to accept recipe input when applying one with Project Browser

Synced with 2.0.x and addressed your feedback!

Self-assigning for tests, and to figure out the test failures.

Wrote a test for this, no problem.

Ready for review. The test failures are also present in HEAD; see #3494672-8: Allow sources to expose a local task → .

Great work, thanks!

Manually tested.

There was an issue on 11.0.4(?) that Adam already fixed, regarding missing property $input.

I think bumped my Drupal version to 11.1.0 and tested with the default website contact feedback form recipe, which worked great - prompting me for an email address, applying steps using a batch API progress meter, and dropped me right back where I expected.

I think tried with drupal/drupal_cms_analytics recipe, but I never got to the screen where I needed to enter my analytics ID. Instead I got to this URL https://pb11.ddev.site/admin/modules/browse/recipe-input?recipe=/var/www... with an error:

The website encountered an unexpected error. Try again later.

Symfony\Component\Validator\Exception\ValidationFailedException: Object(Drupal\Core\TypedData\Plugin\DataType\StringData): This value should not be blank. (code c1051bb4-d103-4f74-8988-acbcafc7fdc3) in Drupal\Core\Recipe\InputConfigurator->collectAll() (line 162 of core/lib/Drupal/Core/Recipe/InputConfigurator.php).
Drupal\project_browser\Form\RecipeForm->buildRecipeInputForm() (Line: 41)
...yadda yadda yadda...

Additional info, I tried to adjust the recipe.yml to something valid, and though I now get the prompt for my tag ID, it fails after submitting that with:

The website encountered an unexpected error. Try again later.

LogicException: Input values cannot be changed once they have been set. in Drupal\Core\Recipe\InputConfigurator->collectAll() (line 141 of core/lib/Drupal/Core/Recipe/InputConfigurator.php).
Drupal\Core\Recipe\InputConfigurator->collectAll() (Line: 139)
Drupal\project_browser\Form\RecipeForm->setRecipeInput() (Line: 112)
Drupal\project_browser\Form\RecipeForm->validateRecipeInput() (Line: 58)
Drupal\project_browser\Form\RecipeForm->validateForm()
...

Though these may be issues in the recipe(s), I wonder if we should handle them in a slightly better way.

The exception in #12, it turns out, is due to a core bug: 🐛 Recipes that depend on other recipes break RecipeInputFormTrait Active

The good news is, we can work around it.

This now has strong test coverage, against the drupal_cms_analytics recipe itself (which is now a dev dependency).

I think it's ready for review.

Checked on 11.0 and got an error relative to the Analytics recipe, which is expected! So, good there anyway,

Went to 11.1 and got all the way through the input, and then the application, then looks like we missed new requirements from the other issue (project_browser.browse now requires a source param).

Tests broken already, fixing in related issue. Manually tested and reviewed.

This is a great step in the direction of introducing user interaction during Activation of a project. Love it! And it makes recipes SO powerful.

Automatically closed - issue fixed for 2 weeks with no activity.