Add array return to all *_info hook implementations

Looks good! Baseline looks right too.

I left some questions in the MR. Also, why are these not changed?

$ grep -r 'function.*hook_info(' core | grep -v array
core/tests/Drupal/Tests/Core/Extension/modules/module_handler_test/module_handler_test.module:function module_handler_test_hook_info() {
core/tests/Drupal/Tests/Core/GroupIncludesTestTrait.php:function test_module_hook_info() {
core/lib/Drupal/Core/Hook/HookCollectorPass.php:   * A list of functions implementing hook_hook_info().
core/modules/views/views.module:function views_hook_info() {
core/modules/system/tests/modules/module_test/module_test.module:function module_test_hook_info() {
core/modules/system/system.module:function system_hook_info() {

Responded to some of the MR feedback, need further advice. Will look at the entity.api.php feedback too, it wasn't loading in the MR though.

Re #5:

• The *_hook_infohooks were missed because my script was looking for a #[Hook] attribute in Hook classes. Could possibly be skipped due to 📌 Deprecate hook_hook_info() Active
• test_module_hook_info is actually in a heredoc string for writing a .module in a test, but I guess it could be included too
• HookCollectorPass is just a comment talking about info hooks

Addressed most feedback, 2 outstanding items in the MR for re-review.

Needs rebase

Hi @mstrelan

I resolved the Merge conflict in Baseline and Rebased the branch to the latest.
But the PHPSTAN pipeline shows some error in Baseline.
Can you please look into it

Best not to manually resolve conflicts in the baseline, just regenerate it.

I am a bit occupied with something right now, I rebased the branch but there were some PHPUnit errors, can someone please regenerate the baseline.
Thanks

Rebased with these steps:

• git rebase -i 11.x
• Drop the baseline commit
• Regenerate baseline with ./vendor/bin/phpstan --configuration=core/phpstan.neon.dist --generate-baseline=core/.phpstan-baseline.php
• git add core/.phpstan-baseline.php
• Commit and force push

Those steps good but you mean --force-with-lease right?

Rebased

Pipeline passed with all no errors/warnings

@akulsaxena unless the issue doesn't apply or the review bot kicks back a rebase is not needed.

Appears to be 2 open threads so leaving in review. As far as the workspace thread, even though we know workspaces is being updated think we have to make sure nothing bad is introduced here as we don't fully know when those overhaul tickets will land.

Okay this has sat for a bit.

The first thread appears to have an open discussion.

For the workspace one should we postpone till workspace is refactored?

Rebased the MR.

The first thread appears to have an open discussion.

I have refactored this as requested.

For the workspace one should we postpone till workspace is refactored?

Don't think so, there is no harm in leaving it in.

Now it actually does need a rebase.

I have rebased the MR, resolved the conflict, and followed the steps outlined in #14. I have also verified the PHP Stan baseline. Since the pipeline is now green, Checked the threads , but nothing open so moving this back to 'Needs Review'.

Needs a rebase.

I am working on it

Rebase & fixed conflict,moving this NR.

This rebase seems to hold for now.

Sorry, needs another rebase.

Rebased this without encountering any conflicts

Sorry still needs a rebase

If you are another contributor eager to jump in, please allow the previous poster at 8 hours to respond to feedback first, so they have the opportunity to finish what they started!

Rebased & fixed conflicts :)

The rebase seems to hold for now
Can be moved to RTBC now, i worked on this so cant move it to RTBC, will wait for someone else to RTBC this.

Thanks @shalini_jha!

Before applying the diff these are the info hooks with a return type. The void agrees with the Issue Summary.
(11.x)$ git grep -A1 "#\[Hook.*_info')" | grep \):
core/modules/config_translation/src/Hook/ConfigTranslationHooks.php- public function configTranslationInfo(&$info): void {
core/modules/file/src/Hook/TokenHooks.php- public function tokenInfo(): array {
core/modules/system/tests/modules/plugin_test/src/Hook/PluginTestHooks.php- public function testPluginInfo(): array {
core/modules/workspaces/src/Hook/EntityTypeInfo.php- public function entityBaseFieldInfo(EntityTypeInterface $entity_type): array {

After applying the diff and search for info hooks with an array return, there is just the config one, as expected.
(11.x)$ git grep -A1 "#\[Hook.*_info')" | grep function | grep -v ": array"
core/modules/config_translation/src/Hook/ConfigTranslationHooks.php- public function configTranslationInfo(&$info): void {

Committed 873f84f and pushed to 11.x. Thanks!

quietone → closed merge request !10282

Automatically closed - issue fixed for 2 weeks with no activity.