- Issue created by @pdureau
- Merge request !56Issue #3488789 by pdureau: Use #allowed_icon_pack with UI Patterns 2 → (Merged) created by pdureau
- 🇫🇷France pdureau Paris
MR ready: https://git.drupalcode.org/project/ui_icons/-/merge_requests/56
But i still have a warning to fix:
Warning: Undefined array key 1 in Drupal\ui_icons_patterns\Plugin\UiPatterns\Source\IconSource->getPropValue() (line 29 of modules/custom/ui_icons/modules/ui_icons_patterns/src/Plugin/UiPatterns/Source/IconSource.php).
- 🇫🇷France just_like_good_vibes PARIS
i am using that work in UI suite DSFR theme, see Issue 3484134 📌 [1.1.x] Adopts the new Icon API Active
- 🇫🇷France just_like_good_vibes PARIS
using the code from this MR, i have some problems in UI patterns 2, when i configure some components in the interface
(in my case a tag), the validation that is triggered during form clicking is raising an error inComponentValidator
:[icon.pack_id] Does not have a value in the enumeration ["dsfr"]
Indeed, i have a prop icon with a pack_id allowed "dsfr", but in my component context, i have for icon :
pack_id = ""
andicon_id=""
.My icon is empty, and that is raising an error, how should be tackle this case?
- 🇫🇷France just_like_good_vibes PARIS
i just proposed a small workaround to cover the case i just described.
someone would like to review?
- First commit to issue fork.
-
mogtofu33 →
committed c12ccd90 on 1.0.x authored by
pdureau →
Issue #3488789 by pdureau, just_like_good_vibes, mogtofu33: Use #...
-
mogtofu33 →
committed c12ccd90 on 1.0.x authored by
pdureau →
Automatically closed - issue fixed for 2 weeks with no activity.