- Issue created by @pdureau
- 🇫🇷France just_like_good_vibes PARIS
i will take it.
@pdureau, do you suggest that we should wait before adopting ui_icons?like waiting for the core MR to be merged or waiting for a stable version of ui_icons module?
- 🇫🇷France pdureau Paris
@pdureau, do you suggest that we should wait before adopting ui_icons?
It is a breaking change for UI Suite DSFR, so we need to do it for 1.1.0, not later. We will not introduce breaking changes in patch releases (1.1.1, 1.1.2, 1.1.3....).
Today, the
iconprop type and its related source plugin are found in this module: https://git.drupalcode.org/project/ui_icons/-/tree/1.0.x/modules/ui_icon.... But it will move in https://git.drupalcode.org/project/ui_patterns/-/tree/2.0.x/src/Plugin/U... as soon as ✨ Add an icon management API Active is merged.The plugin ID will not change, it will stay
icon, so we can start with https://git.drupalcode.org/project/ui_icons/-/tree/1.0.x/modules/ui_icon... (let's not forget the temporary dependency) - 🇫🇷France pdureau Paris
we also need to remove the corresponding style utility (in
ui_suite_dsfr.ui_styles.yml) ? And what about the related icon size utility?