- Issue created by @spokje
- π³π±Netherlands spokje
Postponed on the landing of π stylelint-formatter-gitlab prevents updating stylelint Active since
leon0399/stylelint-formatter-gitlab
does not work withstylelint
versions above 15.x. - π¬π§United Kingdom longwave UK
The formatter change has landed so finally we can action this.
- π³π±Netherlands spokje
spokje β changed the visibility of the branch 11.x to hidden.
- π³π±Netherlands spokje
spokje β changed the visibility of the branch 3488005-10.5.x-bump-stylelint to hidden.
- π¬π§United Kingdom longwave UK
After applying this MR, running
yarn lint:css
locally seems to hang forever now, not sure why. - π³π±Netherlands spokje
@longwave Can't reproduce that locally.
Also https://git.drupalcode.org/issue/drupal-3488005/-/jobs/3485149#L272 indicates that the same command, but with added frills like caching and custom formatters does, at the very returns and doesn't get stuck.
- π¬π§United Kingdom longwave UK
Yeah it's probably something specific to my local environment, will have to figure out what. I tried deleting
node_modules
and reinstalling but that made no difference. - πΊπΈUnited States smustgrave
Not super fast and since there is no progress indicator I thought maybe it got hung up on my local ddev too but it did complete after about a minute.
- π¬π§United Kingdom catch
On my local this is fine.
time yarn lint:css real 0m13.286s user 0m18.873s sys 0m2.998s
Would be good to get another try from @longwave since this runs on commit, so we don't want a situation where we commit this, then @longwave can't commit any patches until the problem is fixed.
-
longwave β
committed 05391a62 on 11.1.x
Issue #3488005 by spokje: Update stylelint* to latest releases (cherry...
-
longwave β
committed 05391a62 on 11.1.x
-
longwave β
committed 7f47553b on 11.x
Issue #3488005 by spokje: Update stylelint* to latest releases
-
longwave β
committed 7f47553b on 11.x
- π¬π§United Kingdom longwave UK
It must be something to do with my core development playground directory, because it only hangs there.
I have a separate clean checkout for committing, and there I get a similar result to @catch:
$ time yarn lint:css real 0m12.274s user 0m18.059s sys 0m2.209s
Committed and pushed 7f47553bf9c to 11.x and 05391a62745 to 11.1.x. Thanks!
Marking PTBP to pull this back to 10.5.x/10.4.x.
- π³π±Netherlands spokje
spokje β changed the visibility of the branch 3488005-10.5.x-bump-stylelint to active.
- π³π±Netherlands spokje
spokje β changed the visibility of the branch 3488005-11.x-bump-stylelint to hidden.
- π³π±Netherlands spokje
What have we learned:
1. Updating an MR on non-11.x in a branch made from 11.x many moons ago is a nightmare
2. Not-so-random-failures in 10.5.x tests that don't seem related to the changes in this MR. Dropped a few lines in Slack about this. - π³π±Netherlands spokje
Right some rollbacks later, and we have a green MR.
- First commit to issue fork.
-
longwave β
committed 6995c903 on 10.4.x
Issue #3488005 by spokje, nod_, longwave: Update stylelint* to latest...
-
longwave β
committed 6995c903 on 10.4.x
- π¬π§United Kingdom longwave UK
-
longwave β
committed 6b00903d on 10.5.x
Issue #3488005 by spokje, nod_, longwave: Update stylelint* to latest...
-
longwave β
committed 6b00903d on 10.5.x