- Issue created by @catch
- 🇬🇧United Kingdom catch
With this change, DefaultPluginManager test only shows up in job 2:
- 🇨🇭Switzerland berdir Switzerland
And the total amount of tests goes from 28879 to 28526, that's about 350 less, that's quite a bit, about 1%?
Not familiar with that code, so not feeling confident enough to RTBC. It's in run-tests.sh, but this thing is fairly complex, any chance we can put this in a class and test it?
- 🇬🇧United Kingdom catch
@berdir that sounds potentially about right for the reduction - I think it would affect any test that has two @group annotations (other than @group #slow which was already made unique).
There's #2624926: Refactor run-tests.sh for Console component. → open to refactor run-tests.sh. I also think there's some functionality we can drop, although we'll need to be careful with the contrib gitlab templates which use different features to core.
- 🇺🇸United States smustgrave
I've definitely seen this issue before. Especially when I was working on that body auto-create removal ticket and getting a number of failures.
Don't see any issue with using array_unique (makes sense). Will go on a limb and mark this one.
- 🇳🇿New Zealand quietone
I was looking at the different counts of tests in run-tests.sh. On HEAD today I was getting 4,101 non slow tests and with the MR that was reduced to 3,972. That is a difference of 129 which is much less that what is mentioned in #5.
- 🇬🇧United Kingdom catch
@quietone run-tests.sh will show test classes, gitlab ci will include test methods (possibly even taking into account data providers).
Automatically closed - issue fixed for 2 weeks with no activity.