- Issue created by @geek-merlin
- @geek-merlin opened merge request.
- π©πͺGermany geek-merlin Freiburg, Germany
Trivial MR flying in.
Commit url applies cleanly on my site and fixes the issue for me: https://git.drupalcode.org/project/drupal/-/commit/900e76dac8973176991a0...
- π©πͺGermany geek-merlin Freiburg, Germany
Trivial MR flying in.
Commit url applies cleanly on my site and fixes the issue for me.
And pipeline is green now.
- πΊπΈUnited States smustgrave
Wonder if while we are at it we should use constructor promotion so all the params are correct typehinted.
Just to be safe though I wonder if we should add a simple deprecation that triggers if someone passes in the old type. Just to be safe.
- π§πͺBelgium BramDriesen Belgium π§πͺ
I can confirm the mr/patch fixes the issue for me as well. Was getting the exact same error as in the IS.
Will leave it at NW for #5.
- π©πͺGermany geek-merlin Freiburg, Germany
@smustgrave
> Just to be safe though I wonder if we should add a simple deprecation that triggers if someone passes in the old type. Just to be safe.Sounds like sth got confused: Is so "passes in the old type" (LazyContextRepository), it is always an instance of ContextRepositoryInterface (the "new type") and will always be. So nothing to deprecate here.
RTBC as of #6.
-
larowlan β
committed 8638abca on 10.4.x
Issue #3487586 by geek-merlin: BlockLibraryController typehints...
-
larowlan β
committed 8638abca on 10.4.x
-
larowlan β
committed a031f244 on 10.5.x
Issue #3487586 by geek-merlin: BlockLibraryController typehints...
-
larowlan β
committed a031f244 on 10.5.x
-
larowlan β
committed 0e2d34fb on 11.1.x
Issue #3487586 by geek-merlin: BlockLibraryController typehints...
-
larowlan β
committed 0e2d34fb on 11.1.x
-
larowlan β
committed 7a0fee2e on 11.x
Issue #3487586 by geek-merlin: BlockLibraryController typehints...
-
larowlan β
committed 7a0fee2e on 11.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 11.x and backported to 10.4, 10.5 and 11.1
No backport to 11.0 and 10.3 as they're now security only.
Automatically closed - issue fixed for 2 weeks with no activity.